-
-
Notifications
You must be signed in to change notification settings - Fork 84
Release v0.1.0-alpha.74 #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ains chore: disable notifications and domain pages for now
WalkthroughThis PR temporarily disables several UI features and navigation items (notifications, domains, SMTP banner) and implements WebSocket message queuing and safer monitoring lifecycle handling across socket and monitoring providers. A version timestamp in api/versions.json was also updated. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (17)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
view/app/dashboard/hooks/use-smtp-banner.ts(1 hunks)view/app/dashboard/page.tsx(4 hunks)view/app/settings/domains/page.tsx(2 hunks)view/app/settings/notifications/page.tsx(2 hunks)view/hooks/use-app-sidebar.ts(1 hunks)
🔇 Additional comments (4)
view/hooks/use-app-sidebar.ts (1)
64-80: LGTM - Navigation items properly disabled.The notifications and domains navigation items are cleanly removed with TODO comments for future re-enablement. The imports for their related APIs are correctly retained since they're still used in
resetApiStates()at lines 131-142.view/app/settings/notifications/page.tsx (1)
23-35: Good approach to disabled state handling.The early return with an informative message provides better user experience than a blank page. This approach should be the standard for temporarily disabled features across the codebase.
view/app/dashboard/hooks/use-smtp-banner.ts (1)
25-28: LGTM - Appropriate fallback for disabled notifications.The redirect to general settings is a reasonable fallback while the notifications feature is disabled. The hook logic is preserved for when the SMTP banner is re-enabled.
view/app/dashboard/page.tsx (1)
18-19: LGTM - Clean temporary removal of SMTP banner.The SMTP banner feature is consistently disabled across all touchpoints (import, destructuring, rendering, component definition). The code structure is well-preserved with TODO comments for future re-enablement.
Also applies to: 38-39, 113-114, 195-199
Issue
Link to related issue(s):
Description
Short summary of what this PR changes or introduces.
Scope of Change
Select all applicable areas impacted by this PR:
Screenshot / Video / GIF (if applicable)
Attach or embed screenshots, screen recordings, or GIFs demonstrating the feature or fix.
Related PRs (if any)
Link any related or dependent PRs across repos.
Additional Notes for Reviewers (optional)
Anything reviewers should know before testing or merging (e.g., environment variables, setup steps).
Developer Checklist
To be completed by the developer who raised the PR.
Reviewer Checklist
To be completed by the reviewer before merge.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.