Skip to content

Commit cf5e84c

Browse files
committed
Update models_skybox_rendering.c
1 parent f171948 commit cf5e84c

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

examples/models/models_skybox_rendering.c

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@ int main(void)
5454
Mesh cube = GenMeshCube(1.0f, 1.0f, 1.0f);
5555
Model skybox = LoadModelFromMesh(cube);
5656

57-
// Set this to true to use an HDR Texture, Note that raylib must be built with HDR Support for this to work SUPPORT_FILEFORMAT_HDR
57+
// Set this to true to use an HDR Texture
58+
// NOTE: raylib must be built with HDR Support for this to work: SUPPORT_FILEFORMAT_HDR
5859
bool useHDR = false;
5960

6061
// Load skybox shader and set required locations
@@ -63,8 +64,8 @@ int main(void)
6364
TextFormat("resources/shaders/glsl%i/skybox.fs", GLSL_VERSION));
6465

6566
SetShaderValue(skybox.materials[0].shader, GetShaderLocation(skybox.materials[0].shader, "environmentMap"), (int[1]){ MATERIAL_MAP_CUBEMAP }, SHADER_UNIFORM_INT);
66-
SetShaderValue(skybox.materials[0].shader, GetShaderLocation(skybox.materials[0].shader, "doGamma"), (int[1]) { useHDR ? 1 : 0 }, SHADER_UNIFORM_INT);
67-
SetShaderValue(skybox.materials[0].shader, GetShaderLocation(skybox.materials[0].shader, "vflipped"), (int[1]){ useHDR ? 1 : 0 }, SHADER_UNIFORM_INT);
67+
SetShaderValue(skybox.materials[0].shader, GetShaderLocation(skybox.materials[0].shader, "doGamma"), (int[1]){ useHDR? 1 : 0 }, SHADER_UNIFORM_INT);
68+
SetShaderValue(skybox.materials[0].shader, GetShaderLocation(skybox.materials[0].shader, "vflipped"), (int[1]){ useHDR? 1 : 0 }, SHADER_UNIFORM_INT);
6869

6970
// Load cubemap shader and setup required shader locations
7071
Shader shdrCubemap = LoadShader(TextFormat("resources/shaders/glsl%i/cubemap.vs", GLSL_VERSION),
@@ -91,9 +92,11 @@ int main(void)
9192
}
9293
else
9394
{
94-
Image img = LoadImage("resources/skybox.png");
95-
skybox.materials[0].maps[MATERIAL_MAP_CUBEMAP].texture = LoadTextureCubemap(img, CUBEMAP_LAYOUT_AUTO_DETECT); // CUBEMAP_LAYOUT_PANORAMA
96-
UnloadImage(img);
95+
// TODO: WARNING: On PLATFORM_WEB it requires a big amount of memory to process input image
96+
// and generate the required cubemap image to be passed to rlLoadTextureCubemap()
97+
Image image = LoadImage("resources/skybox.png");
98+
skybox.materials[0].maps[MATERIAL_MAP_CUBEMAP].texture = LoadTextureCubemap(image, CUBEMAP_LAYOUT_AUTO_DETECT);
99+
UnloadImage(image);
97100
}
98101

99102
DisableCursor(); // Limit cursor to relative movement inside the window
@@ -132,9 +135,9 @@ int main(void)
132135
}
133136
else
134137
{
135-
Image img = LoadImage(droppedFiles.paths[0]);
136-
skybox.materials[0].maps[MATERIAL_MAP_CUBEMAP].texture = LoadTextureCubemap(img, CUBEMAP_LAYOUT_AUTO_DETECT);
137-
UnloadImage(img);
138+
Image image = LoadImage(droppedFiles.paths[0]);
139+
skybox.materials[0].maps[MATERIAL_MAP_CUBEMAP].texture = LoadTextureCubemap(image, CUBEMAP_LAYOUT_AUTO_DETECT);
140+
UnloadImage(image);
138141
}
139142

140143
TextCopy(skyboxFileName, droppedFiles.paths[0]);

0 commit comments

Comments
 (0)