Tweaks space width/height methods/tests

Author: brgix

lib/osut/utils.rb

@@ -4565,8 +4565,8 @@ def alignedHeight(pts = nil, force = false)
   def spaceHeight(space = nil)
     return 0 unless space.is_a?(OpenStudio::Model::Space)
 
-    minZ = 1000
-    maxZ = 0
+    minZ =  10000
+    maxZ = -10000
 
     space.surfaces.each do |surface|
       minZ = [surface.vertices.min_by(&:z).z, minZ].min
@@ -4599,6 +4599,7 @@ def spaceWidth(space = nil)
     #   - retain only other floor surfaces sharing same 3D plane
     #   - recover potential union between floor surfaces
     #   - fall back to largest floor surface if invalid union
+    #   - return width of largest bounded box
     floors = floors.sort_by(&:grossArea).reverse
     floor  = floors.first
     plane  = floor.plane
@@ -4622,6 +4623,7 @@ def spaceWidth(space = nil)
     res = realignedFace(polyg.to_a.reverse)
     return 0 if res[:box].nil?
 
+    # A bounded box's 'height', at its narrowest, is its 'width'.
     height(res[:box])
   end
 

spec/osut_tests_spec.rb

@@ -5743,7 +5743,7 @@ module M
 
     # The Fine Storage space has 2 floors, at different Z-axis levels:
     # - main ground floor (slab on grade), Z=0.00m
-    # - a mezzanine floor, adjacent to the office space ceiling below, Z=4.27m
+    # - mezzanine floor, adjacent to the office space ceiling below, Z=4.27m
     expect(mod1.facets(fine, "all", "floor").size).to eq(2)
     groundfloor = model.getSurfaceByName("Fine Storage Floor")
     mezzanine   = model.getSurfaceByName("Office Roof Reversed")
@@ -5755,10 +5755,10 @@ module M
     # The ground floor is L-shaped, floor surfaces have differenet Z=axis
     # levels, etc. In the context of codes/standards like ASHRAE 90.1 or the
     # Canadian NECB, determining what constitutes a space's 'height' and/or
-    # 'width' can matter, namely with regards to geometry-based LPD rules (e.g.
-    # adjustments per corridor 'width'). Not stating here what the definitive
-    # answers should be in all cases. There are however a few OSut functions
-    # that may be useful.
+    # 'width' matters, namely with regards to geometry-based LPD rules (e.g.
+    # adjustments based on corridor 'width'). Not stating here what the
+    # definitive answers should be in all cases. There are however a few OSut
+    # functions that may be helpful.
     #
     # OSut's 'aligned' height and width functions were initially developed for
     # non-flat surfaces, like walls and sloped roofs - particularly useful when
@@ -5778,11 +5778,13 @@ module M
 
     # OSut's 'spaceHeight' and 'spaceWidth' are more suitable for height- or
     # width-based LPD adjustement calculations. OSut sets a space's width as
-    # the widest edge of the largest bounded box it can fit within a collection
-    # of neighbouring floor surfaces. This is considered reasonable for a long
-    # corridor, with a varying width along its full length. Achtung! The
-    # function can be time consuming for very convoluted spaces (e.g. long
-    # corridors with multiple concavities).
+    # the length of the narrowest edge of the largest bounded box that fits
+    # within a collection of neighbouring floor surfaces. This is considered
+    # reasonable for a long corridor, with varying widths along its full
+    # length (e.g. occasional alcoves).
+    #
+    # Achtung! The function can be time consuming (multiple iterations) for
+    # very convoluted spaces (e.g. long corridors with multiple concavities).
     expect(mod1.spaceHeight(fine)).to be_within(TOL).of(8.53)
     expect(mod1.spaceWidth(fine)).to be_within(TOL).of(21.33)