Updates SEB fix tests

Author: brgix

spec/osut_tests_spec.rb

@@ -367,29 +367,87 @@
 
   it "checks construction thickness" do
     translator = OpenStudio::OSVersion::VersionTranslator.new
+    version    = OpenStudio.openStudioVersion.split(".").join.to_i
     expect(cls1.clean!).to eq(DBG)
 
+    # The v1.11.5 (2016) seb.osm, shipped with OpenStudio, holds (what would now
+    # be considered as deprecated) a definition of plenum floors (i.e. ceiling
+    # tiles) generating several warnings with more recent OpenStudio versions.
     file  = File.join(__dir__, "files/osms/in/seb.osm")
     path  = OpenStudio::Path.new(file)
     model = translator.loadModel(path)
     expect(model).to_not be_empty
     model = model.get
 
-    # -- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- cleanup   #
-    # This is the first test relying on the 'seb.osm' file, which ships with
-    # OpenStudio. The v1.11.5 model (2016) holds a number of artefacts that
-    # would be frowned upon today (e.g. plenum floors tagged as roofs/ceilings).
+    # "Shading Surface 4" is overlapping with a plenum exterior wall.
+    sh4 = model.getShadingSurfaceByName("Shading Surface 4")
+    expect(sh4).to_not be_empty
+    sh4 = sh4.get
+    sh4.remove
+
     plenum = model.getSpaceByName("Level 0 Ceiling Plenum")
     expect(plenum).to_not be_empty
     plenum = plenum.get
 
+    thzone = plenum.thermalZone
+    expect(thzone).to_not be_empty
+    thzone = thzone.get
+
+    # Before the fix.
+    unless version < 350
+      expect(plenum.isEnclosedVolume).to be true
+      expect(plenum.isVolumeDefaulted).to be true
+      expect(plenum.isVolumeAutocalculated).to be true
+    end
+
+    if version > 350 && version < 370
+      expect(plenum.volume.round(0)).to eq(234)
+    else
+      expect(plenum.volume.round(0)).to eq(0)
+    end
+
+    expect(thzone.isVolumeDefaulted).to be true
+    expect(thzone.isVolumeAutocalculated).to be true
+    expect(thzone.volume).to be_empty
+
     plenum.surfaces.each do |s|
       next if s.outsideBoundaryCondition.downcase == "outdoors"
 
+      # If a SEB plenum surface isn't facing outdoors, it's 1 of 4 "floor"
+      # surfaces (each facing a ceiling surface below).
+      adj = s.adjacentSurface
+      expect(adj).to_not be_empty
+      adj = adj.get
+      expect(adj.vertices.size).to eq(s.vertices.size)
+
+      # Same vertex sequence? Should be in reverse order.
+      adj.vertices.each_with_index do |vertex, i|
+        expect(mod1.same?(vertex, s.vertices.at(i))).to be true
+      end
+
+      expect(adj.surfaceType).to eq("RoofCeiling")
+      expect(s.surfaceType).to eq("RoofCeiling")
       expect(s.setSurfaceType("Floor")).to be true
       expect(s.setVertices(s.vertices.reverse)).to be true
+
+      # Vertices now in reverse order.
+      adj.vertices.reverse.each_with_index do |vertex, i|
+        expect(mod1.same?(vertex, s.vertices.at(i))).to be true
+      end
     end
 
+    # After the fix.
+    unless version < 350
+      expect(plenum.isEnclosedVolume).to be true
+      expect(plenum.isVolumeDefaulted).to be true
+      expect(plenum.isVolumeAutocalculated).to be true
+    end
+
+    expect(plenum.volume.round(0)).to eq(50) # right answer
+    expect(thzone.isVolumeDefaulted).to be true
+    expect(thzone.isVolumeAutocalculated).to be true
+    expect(thzone.volume).to be_empty
+
     file = File.join(__dir__, "files/osms/out/seb2.osm")
     model.save(file, true)
     # --- --- --- --- --- --- --- --- --- --- --- --- --- --- end of cleanup   #