Skip to content

Commit dc9a689

Browse files
authored
Merge pull request #653 from reactioncommerce/chore-dc-network-rename
chore: reconfigure docker-compose networks
2 parents 8c390a9 + a04c1b4 commit dc9a689

File tree

4 files changed

+11
-15
lines changed

4 files changed

+11
-15
lines changed

.env.example

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
CANONICAL_URL=http://localhost:4000
22
ENABLE_SPA_ROUTING=true
33
EXTERNAL_GRAPHQL_URL=http://localhost:3000/graphql
4-
INTERNAL_GRAPHQL_URL=http://api.api.reaction.localhost:3000/graphql
4+
INTERNAL_GRAPHQL_URL=http://api.reaction.localhost:3000/graphql
55
OAUTH2_ADMIN_PORT=4445
6-
OAUTH2_ADMIN_URL=http://hydra.auth.reaction.localhost:4445
6+
OAUTH2_ADMIN_URL=http://hydra.reaction.localhost:4445
77
OAUTH2_AUTH_URL=http://localhost:4444/oauth2/auth
88
OAUTH2_CLIENT_ID=example-storefront
99
OAUTH2_CLIENT_SECRET=CHANGEME
1010
OAUTH2_PUBLIC_LOGOUT_URL=http://localhost:4444/oauth2/sessions/logout
11-
OAUTH2_HOST=hydra.auth.reaction.localhost
11+
OAUTH2_HOST=hydra.reaction.localhost
1212
OAUTH2_IDP_PUBLIC_CHANGE_PASSWORD_URL=http://localhost:4100/account/change-password?email=EMAIL&from=FROM
13-
OAUTH2_IDP_HOST_URL=http://identity.auth.reaction.localhost:4100
14-
OAUTH2_TOKEN_URL=http://hydra.auth.reaction.localhost:4444/oauth2/token
13+
OAUTH2_IDP_HOST_URL=http://identity.reaction.localhost:4100
14+
OAUTH2_TOKEN_URL=http://hydra.reaction.localhost:4444/oauth2/token
1515
PORT=4000
1616
SEGMENT_ANALYTICS_SKIP_MINIMIZE=true
1717
SEGMENT_ANALYTICS_WRITE_KEY=ENTER_KEY_HERE

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,7 @@ docker build -t reaction-storefront .
188188
Then, to start the app on your machine, make sure the Reaction API container is already running and enter:
189189

190190
```sh
191-
docker run -it --name storefront -p 4000:4000 --env-file .env --network api.reaction.localhost reaction-storefront
192-
docker network connect auth.reaction.localhost storefront
191+
docker run -it --name storefront -p 4000:4000 --env-file .env --network reaction.localhost reaction-storefront
193192
```
194193

195194
_**NOTE:** You can replace the number before the colon in `4000:4000` with a different localhost port you'd like the application to run at._

docker-compose.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,20 +7,17 @@
77
version: '3.4'
88

99
networks:
10-
api:
10+
reaction:
1111
external:
12-
name: api.reaction.localhost
13-
auth:
14-
external:
15-
name: auth.reaction.localhost
12+
name: reaction.localhost
1613

1714
services:
1815
web:
1916
image: reactioncommerce/example-storefront:release-v3.0.0
2017
env_file:
2118
- ./.env
2219
networks:
23-
api:
24-
auth:
20+
default:
21+
reaction:
2522
ports:
2623
- 4000:4000

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"test:unit": "NODE_ENV=jesttest jest",
2424
"test:unit:watch": "NODE_ENV=jesttest jest --watchAll",
2525
"test:integration": "mocha tests/integration",
26-
"test:link": "blc http://web.api.reaction.localhost:4000 -ro -filter=3 -e",
26+
"test:link": "blc http://web.reaction.localhost:4000 -ro -filter=3 -e",
2727
"test:file": "NODE_ENV=jesttest jest --watch --no-coverage"
2828
},
2929
"eslintConfig": {

0 commit comments

Comments
 (0)