Skip to content

[Bug]: ReactiveCommand naming convention goes against ReactiveUI guidelinse #315

@kgday

Description

@kgday

Describe the bug 🐞

In
https://www.reactiveui.net/docs/guidelines/framework/command-names.html

The guidelines state not to suffix your commands with 'Command'. But that is exactly what the source generator does. In my manual method I would prefix my methods with 'Do'. I notice though that the above doc I quoted encourages you to use 'Impl' as the suffix. Currently though if you do that you still have 'Command' appended to that and end up with ImplCommand. This breaks a lot of code where I convert to using the source generator. Maybe the original thinking and document should be changed. It would appear that a lot of people do not follow this guidelne.

Step to reproduce

Use the [ReactiveCommand] attribute as documented.

Reproduction repository

https://github.com/reactiveui/ReactiveUI

Expected behavior

This should happen...

Screenshots 🖼️

No response

IDE

No response

Operating system

No response

Version

No response

Device

No response

ReactiveUI Version

No response

Additional information ℹ️

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions