[1.x] Fix SPL SplObjectStorage deprecations

In PHP8.5 the SplObjectStorage::contains, SplObjectStorage::attach, and SplObjectStorage::detach methods have been deprecated through https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_splobjectstoragecontains_splobjectstorageattach_and_splobjectstoragedetach

Author: WyriHaximus

src/ExtEvLoop.php

@@ -143,13 +143,13 @@ public function addTimer($interval, $callback)
         $callback = function () use ($timer, $timers, $that) {
             \call_user_func($timer->getCallback(), $timer);
 
-            if ($timers->contains($timer)) {
+            if ($timers->offsetExists($timer)) {
                 $that->cancelTimer($timer);
             }
         };
 
         $event = $this->loop->timer($timer->getInterval(), 0.0, $callback);
-        $this->timers->attach($timer, $event);
+        $this->timers->offsetSet($timer, $event);
 
         return $timer;
     }
@@ -163,7 +163,7 @@ public function addPeriodicTimer($interval, $callback)
         };
 
         $event = $this->loop->timer($timer->getInterval(), $timer->getInterval(), $callback);
-        $this->timers->attach($timer, $event);
+        $this->timers->offsetSet($timer, $event);
 
         return $timer;
     }
@@ -176,7 +176,7 @@ public function cancelTimer(TimerInterface $timer)
 
         $event = $this->timers[$timer];
         $event->stop();
-        $this->timers->detach($timer);
+        $this->timers->offsetUnset($timer);
     }
 
     public function futureTick($listener)

src/ExtEventLoop.php

@@ -64,7 +64,7 @@ public function __destruct()
     {
         // explicitly clear all references to Event objects to prevent SEGFAULTs on Windows
         foreach ($this->timerEvents as $timer) {
-            $this->timerEvents->detach($timer);
+            $this->timerEvents->offsetUnset($timer);
         }
 
         $this->readEvents = array();
@@ -157,9 +157,9 @@ public function addPeriodicTimer($interval, $callback)
 
     public function cancelTimer(TimerInterface $timer)
     {
-        if ($this->timerEvents->contains($timer)) {
+        if ($this->timerEvents->offsetExists($timer)) {
             $this->timerEvents[$timer]->free();
-            $this->timerEvents->detach($timer);
+            $this->timerEvents->offsetUnset($timer);
         }
     }
 
@@ -243,7 +243,7 @@ private function createTimerCallback()
         $this->timerCallback = function ($_, $__, $timer) use ($timers) {
             \call_user_func($timer->getCallback(), $timer);
 
-            if (!$timer->isPeriodic() && $timers->contains($timer)) {
+            if (!$timer->isPeriodic() && $timers->offsetExists($timer)) {
                 $this->cancelTimer($timer);
             }
         };

src/ExtUvLoop.php

@@ -119,13 +119,13 @@ public function addTimer($interval, $callback)
         $callback = function () use ($timer, $timers, $that) {
             \call_user_func($timer->getCallback(), $timer);
 
-            if ($timers->contains($timer)) {
+            if ($timers->offsetExists($timer)) {
                 $that->cancelTimer($timer);
             }
         };
 
         $event = \uv_timer_init($this->uv);
-        $this->timers->attach($timer, $event);
+        $this->timers->offsetSet($timer, $event);
         \uv_timer_start(
             $event,
             $this->convertFloatSecondsToMilliseconds($interval),
@@ -149,7 +149,7 @@ public function addPeriodicTimer($interval, $callback)
 
         $interval = $this->convertFloatSecondsToMilliseconds($interval);
         $event = \uv_timer_init($this->uv);
-        $this->timers->attach($timer, $event);
+        $this->timers->offsetSet($timer, $event);
         \uv_timer_start(
             $event,
             $interval,
@@ -167,7 +167,7 @@ public function cancelTimer(TimerInterface $timer)
     {
         if (isset($this->timers[$timer])) {
             @\uv_timer_stop($this->timers[$timer]);
-            $this->timers->detach($timer);
+            $this->timers->offsetUnset($timer);
         }
     }