-
Notifications
You must be signed in to change notification settings - Fork 37
fix(workflow-list): show shared workflows for brand new users #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CameronMcClymont
wants to merge
1
commit into
reanahub:master
Choose a base branch
from
CameronMcClymont:fix-cannot-see-shared-workflows
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(workflow-list): show shared workflows for brand new users #429
CameronMcClymont
wants to merge
1
commit into
reanahub:master
from
CameronMcClymont:fix-cannot-see-shared-workflows
+43
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CameronMcClymont
added a commit
to CameronMcClymont/reana-ui
that referenced
this pull request
Jul 18, 2025
…red with them (reanahub#429) Closes reanahub#413
ce020c8 to
156c41b
Compare
CameronMcClymont
added a commit
to CameronMcClymont/reana-ui
that referenced
this pull request
Jul 18, 2025
156c41b to
c397e37
Compare
Member
Author
|
Do we want to change the default filters to 'owned by = anybody' if the user has no workflows of their own? |
|
Hi @CameronMcClymont, there are some merge conflicts here, should I take over the UI PRs? |
CameronMcClymont
added a commit
to CameronMcClymont/reana-ui
that referenced
this pull request
Nov 28, 2025
c397e37 to
17497ae
Compare
Member
Author
@michaelbuchar yes please! PS, commit message improved now. |
michaelbuchar
pushed a commit
to CameronMcClymont/reana-ui
that referenced
this pull request
Dec 1, 2025
17497ae to
0769195
Compare
michaelbuchar
pushed a commit
to CameronMcClymont/reana-ui
that referenced
this pull request
Dec 1, 2025
09d3dcd to
cc7e468
Compare
michaelbuchar
pushed a commit
to CameronMcClymont/reana-ui
that referenced
this pull request
Dec 1, 2025
cc7e468 to
e40668b
Compare
|
@tiborsimko @CameronMcClymont ready for review now! |
michaelbuchar
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial view still shows no workflows as filters are set to 'owned by = you' by default:
But the user can change the filters to see workflows shared with them:
To test
Closes #413