Skip to content

Commit d4ebfcc

Browse files
authored
Build with .NET 5.0 GA (#184) (#185)
* bump to LangVersion 9.0 * Move common properties into a Directory.Build.props * use .NET 5 GA in CI
1 parent df6647d commit d4ebfcc

File tree

7 files changed

+14
-12
lines changed

7 files changed

+14
-12
lines changed

.azure/pipelines/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ trigger:
99
- docs/*
1010

1111
pool:
12-
vmImage: ubuntu-18.04
12+
vmImage: ubuntu-latest
1313

1414
steps:
1515
- task: UseDotNet@2
1616
displayName: 'Install .NET Core SDK'
1717
inputs:
18-
version: '5.0.100-rc.1.20452.10'
18+
version: '5.0.100'
1919
installationPath: $(Agent.ToolsDirectory)/dotnet
2020

2121
- script: dotnet test --configuration Release --logger trx --collect "XPlat code coverage"

.azure/pipelines/docs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ steps:
99
- task: UseDotNet@2
1010
displayName: 'Install .NET Core SDK'
1111
inputs:
12-
version: '5.0.100-rc.1.20452.10'
12+
version: '5.0.100'
1313
installationPath: $(Agent.ToolsDirectory)/dotnet
1414

1515
- script: dotnet restore

.azure/pipelines/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ steps:
88
- task: UseDotNet@2
99
displayName: 'Install .NET Core SDK'
1010
inputs:
11-
version: '5.0.100-rc.1.20452.10'
11+
version: '5.0.100'
1212
installationPath: $(Agent.ToolsDirectory)/dotnet
1313

1414
- script: dotnet pack --configuration Release

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@ on: push
44

55
jobs:
66
build:
7-
runs-on: ubuntu-18.04
7+
runs-on: ubuntu-latest
88

99
steps:
1010
- uses: actions/checkout@v2
1111

1212
- name: Set up .NET Core
1313
uses: actions/setup-dotnet@v1
1414
with:
15-
dotnet-version: '5.0.100-rc.1.20452.10'
15+
dotnet-version: '5.0.100'
1616

1717
- name: dotnet test
1818
run: dotnet test --configuration Release --logger trx --collect "XPlat code coverage"

Directory.Build.props

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<Project>
2+
<PropertyGroup>
3+
<TargetFramework>net5.0</TargetFramework>
4+
<LangVersion>9.0</LangVersion>
5+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
6+
<Nullable>enable</Nullable>
7+
</PropertyGroup>
8+
</Project>

src/Recore.csproj

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,13 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net5.0</TargetFramework>
5-
<LangVersion>preview</LangVersion>
64
<RootNamespace>Recore</RootNamespace>
75
<Version>2.0.0</Version>
86
<AssemblyVersion>$(Version).0</AssemblyVersion>
97
<FileVersion>$(Version).0</FileVersion>
108
<PackageVersion>$(Version)-rc1</PackageVersion>
119
<GenerateDocumentation>true</GenerateDocumentation>
1210
<DocumentationFile>bin/docs/Recore.xml</DocumentationFile>
13-
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
1411
<Authors>Brian Cristante</Authors>
1512
<Company />
1613
<PackageId>RecoreFX</PackageId>
@@ -20,7 +17,6 @@
2017
<Product>RecoreFX</Product>
2118
<Copyright>Copyright (c) 2019 Brian Cristante</Copyright>
2219
<PackageLicenseExpression>MIT</PackageLicenseExpression>
23-
<Nullable>enable</Nullable>
2420
</PropertyGroup>
2521

2622
<ItemGroup>

test/Recore.Tests.csproj

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net5.0</TargetFramework>
54
<IsPackable>false</IsPackable>
65
<RootNamespace>Recore.Tests</RootNamespace>
7-
<Nullable>enable</Nullable>
86
</PropertyGroup>
97

108
<ItemGroup>

0 commit comments

Comments
 (0)