Fix instance-tag (#9561)

As suggested by Meirav, change the dynamic windows keys and instance-tag
so that the parsing is successful.

Author: oswcab

components/kueue/production/stone-prod-p02/queue-config/cluster-queue.yaml

@@ -150,7 +150,7 @@ spec:
     - local
     - localhost
     - macos-mac2metal-arm64
-    - windows-amd64
+    - windows-4xlarge-amd64
     flavors:
     - name: platform-group-3
       resources:
@@ -178,7 +178,7 @@ spec:
         nominalQuota: '1000'
       - name: macos-mac2metal-arm64
         nominalQuota: '5'
-      - name: windows-amd64
+      - name: windows-4xlarge-amd64
         nominalQuota: '5'
   stopPolicy: None
 ---

components/kueue/staging/stone-stage-p01/queue-config/cluster-queue.yaml

@@ -109,7 +109,7 @@ spec:
     - local
     - localhost
     - macos-mac2metal-arm64
-    - windows-amd64
+    - windows-4xlarge-amd64
     flavors:
     - name: platform-group-2
       resources:
@@ -141,7 +141,7 @@ spec:
         nominalQuota: '1000'
       - name: macos-mac2metal-arm64
         nominalQuota: '5'
-      - name: windows-amd64
+      - name: windows-4xlarge-amd64
         nominalQuota: '5'
   stopPolicy: None
 ---

components/multi-platform-controller/base/host-config-chart/templates/host-config.yaml

@@ -1121,20 +1121,20 @@ data:
   # Windows platforms
   {{- if hasKey .Values.dynamicConfigs "windows-amd64" }}
   {{- $config := index .Values.dynamicConfigs "windows-amd64" | default (dict) }}
-  dynamic.windows-amd64.type: {{ index $config "type" | default "aws" | quote }}
-  dynamic.windows-amd64.region: {{ index $config "region" | default "us-east-1" | quote }}
-  dynamic.windows-amd64.ami: {{ default (index $windows "ami") $config.ami | quote }}
-  dynamic.windows-amd64.instance-type: {{ (index $config "instance-type") | default "c5.4xlarge" | quote }}
-  dynamic.windows-amd64.instance-tag: {{ (index $config "instance-tag") | default (printf "%s-windows-amd64" $environment) | quote }}
-  dynamic.windows-amd64.key-name: {{ default (index $windows "key-name") ((index $config "key-name")) | quote }}
-  dynamic.windows-amd64.aws-secret: {{ (index $config "aws-secret") | default "aws-account" | quote }}
-  dynamic.windows-amd64.ssh-secret: {{ (index $config "ssh-secret") | default "aws-ssh-key" | quote }}
-  dynamic.windows-amd64.security-group-id: {{ default (index $windows "security-group-id") ((index $config "security-group-id")) | quote }}
-  dynamic.windows-amd64.max-instances: {{ (index $config "max-instances") | default "5" | quote }}
-  dynamic.windows-amd64.subnet-id: {{ default (index $windows "subnet-id") ((index $config "subnet-id")) | quote }}
-  dynamic.windows-amd64.disk: {{ index $config "disk" | default "100" | quote }}
-  dynamic.windows-amd64.check-interval: {{ (index $config "check-interval") | default "60" | quote }}
-  dynamic.windows-amd64.allocation-timeout: "1200"
+  dynamic.windows-4xlarge-amd64.type: {{ index $config "type" | default "aws" | quote }}
+  dynamic.windows-4xlarge-amd64.region: {{ index $config "region" | default "us-east-1" | quote }}
+  dynamic.windows-4xlarge-amd64.ami: {{ default (index $windows "ami") $config.ami | quote }}
+  dynamic.windows-4xlarge-amd64.instance-type: {{ (index $config "instance-type") | default "c5.4xlarge" | quote }}
+  dynamic.windows-4xlarge-amd64.instance-tag: {{ (index $config "instance-tag") | default (printf "%s-amd64-4xlarge" $environment) | quote }}
+  dynamic.windows-4xlarge-amd64.key-name: {{ default (index $windows "key-name") ((index $config "key-name")) | quote }}
+  dynamic.windows-4xlarge-amd64.aws-secret: {{ (index $config "aws-secret") | default "aws-account" | quote }}
+  dynamic.windows-4xlarge-amd64.ssh-secret: {{ (index $config "ssh-secret") | default "aws-ssh-key" | quote }}
+  dynamic.windows-4xlarge-amd64.security-group-id: {{ default (index $windows "security-group-id") ((index $config "security-group-id")) | quote }}
+  dynamic.windows-4xlarge-amd64.max-instances: {{ (index $config "max-instances") | default "5" | quote }}
+  dynamic.windows-4xlarge-amd64.subnet-id: {{ default (index $windows "subnet-id") ((index $config "subnet-id")) | quote }}
+  dynamic.windows-4xlarge-amd64.disk: {{ index $config "disk" | default "100" | quote }}
+  dynamic.windows-4xlarge-amd64.check-interval: {{ (index $config "check-interval") | default "60" | quote }}
+  dynamic.windows-4xlarge-amd64.allocation-timeout: "1200"
   {{- if (index $config "iops") }}
   dynamic.windows-amd64.iops: {{ index $config "iops" | quote }}
   {{ end }}