Skip to content

Commit 2df6388

Browse files
authored
Fix: macOS configuration now reads archDefaults (#9641)
Add $macos variable to host-config template to read macOS-specific defaults from archDefaults, and add missing host-resource-group-arn and license-configuration-arn to stone-prod-p02 dynamicConfigs. This is the same pattern used by other architectures and could have prevented the failure fixed in the two previous related commits.
1 parent b3f1059 commit 2df6388

File tree

1 file changed

+8
-7
lines changed
  • components/multi-platform-controller/base/host-config-chart/templates

1 file changed

+8
-7
lines changed

components/multi-platform-controller/base/host-config-chart/templates/host-config.yaml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ data:
4141
{{- $arm := (index .Values "archDefaults" "arm64") | default (dict) }}
4242
{{- $amd := (index .Values "archDefaults" "amd64") | default (dict) }}
4343
{{- $windows := (index .Values "archDefaults" "windows-amd64") | default (dict) }}
44+
{{- $macos := (index .Values "archDefaults" "macos-mac2metal-arm64") | default (dict) }}
4445
{{- $environment := .Values.environment | default "prod" }}
4546

4647
# cpu:memory (1:4)
@@ -1030,20 +1031,20 @@ data:
10301031
{{- $config := index .Values.dynamicConfigs "macos-mac2metal-arm64" | default (dict) }}
10311032
dynamic.macos-mac2metal-arm64.type: {{ index $config "type" | default "aws" | quote }}
10321033
dynamic.macos-mac2metal-arm64.region: {{ index $config "region" | default "us-east-1" | quote }}
1033-
dynamic.macos-mac2metal-arm64.ami: {{ default (index $amd "ami") $config.ami | quote }}
1034+
dynamic.macos-mac2metal-arm64.ami: {{ default (index $macos "ami") $config.ami | quote }}
10341035
dynamic.macos-mac2metal-arm64.instance-type: {{ (index $config "instance-type") | default "mac2.metal" | quote }}
10351036
dynamic.macos-mac2metal-arm64.instance-tag: {{ (index $config "instance-tag") | default (printf "%s-arm64-mac2metal" $environment) | quote }}
1036-
dynamic.macos-mac2metal-arm64.key-name: {{ default (index $amd "key-name") ((index $config "key-name")) | quote }}
1037+
dynamic.macos-mac2metal-arm64.key-name: {{ default (index $macos "key-name") ((index $config "key-name")) | quote }}
10371038
dynamic.macos-mac2metal-arm64.aws-secret: {{ (index $config "aws-secret") | default "aws-account" | quote }}
1038-
dynamic.macos-mac2metal-arm64.ssh-secret: {{ (index $config "ssh-secret") | default "aws-ssh-key" | quote }}
1039-
dynamic.macos-mac2metal-arm64.security-group-id: {{ default (index $amd "security-group-id") ((index $config "security-group-id")) | quote }}
1039+
dynamic.macos-mac2metal-arm64.ssh-secret: {{ default (index $macos "ssh-secret") ((index $config "ssh-secret")) | default "aws-ssh-key" | quote }}
1040+
dynamic.macos-mac2metal-arm64.security-group-id: {{ default (index $macos "security-group-id") ((index $config "security-group-id")) | quote }}
10401041
dynamic.macos-mac2metal-arm64.max-instances: {{ (index $config "max-instances") | default "5" | quote }}
1041-
dynamic.macos-mac2metal-arm64.subnet-id: {{ default (index $amd "subnet-id") ((index $config "subnet-id")) | quote }}
1042+
dynamic.macos-mac2metal-arm64.subnet-id: {{ default (index $macos "subnet-id") ((index $config "subnet-id")) | quote }}
10421043
dynamic.macos-mac2metal-arm64.disk: {{ index $config "disk" | default "100" | quote }}
10431044
dynamic.macos-mac2metal-arm64.allocation-timeout: "1200"
10441045
dynamic.macos-mac2metal-arm64.tenancy: "host"
1045-
dynamic.macos-mac2metal-arm64.host-resource-group-arn: {{ index $config "host-resource-group-arn" | quote }}
1046-
dynamic.macos-mac2metal-arm64.license-configuration-arn: {{ index $config "license-configuration-arn" | quote }}
1046+
dynamic.macos-mac2metal-arm64.host-resource-group-arn: {{ default (index $macos "host-resource-group-arn") ((index $config "host-resource-group-arn")) | quote }}
1047+
dynamic.macos-mac2metal-arm64.license-configuration-arn: {{ default (index $macos "license-configuration-arn") ((index $config "license-configuration-arn")) | quote }}
10471048
{{- if (index $config "iops") }}
10481049
dynamic.macos-mac2metal-arm64.iops: {{ index $config "iops" | quote }}
10491050
{{ end }}

0 commit comments

Comments
 (0)