adding new roles to dispatcher #1196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new file: changelogs/fragments/new_dispatch_roles.yml modified: roles/dispatch/defaults/main.yml
Tompage1994
requested changes
Oct 7, 2025
Collaborator
Tompage1994
left a comment
Tompage1994
left a comment
There was a problem hiding this comment.
Just wondering whether team assignments should come after user assignments?
Also, I think this value is documented in the readme as well, so probably needs updating
Collaborator
Author
|
I wasn't positive on what order to put them in, I changed it a couple times and just decided to commit something and let others give feedback. The primary thing I wanted to do is get this out there now. |
modified: roles/dispatch/defaults/main.yml
Contributor
I think the same is true for |
sean-m-sullivan
approved these changes
Oct 7, 2025
Collaborator
|
I'd put them as Team assignments first, than users, Teams should be prioritized over user assignments, |
modified: roles/dispatch/defaults/main.yml modified: roles/dispatch/meta/argument_specs.yml
Tompage1994
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds the new roles to dispatch
How should this be tested?
manually
Is there a relevant Issue open for this?
no
Other Relevant info, PRs, etc
none