Fix gather_facts to false in configure_aap.yml #1205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Gather facts by default runs and is true, The play does not need any host facts, is there a reason we need to start gathering facts and add additional time to a run? We turned off gather facts to make it run faster. |
djdanielsson
requested changes
Oct 8, 2025
Contributor
Author
|
I think there is no reason to start gathering facts. So I set to I apologize for the misleading title. I have corrected it. |
akira6592
changed the title
Tompage1994
approved these changes
Oct 8, 2025
Contributor
Author
|
Thank you for merging! |
Collaborator
|
It was too early and misunderstood, I thought we were changing behavior, this is how it should run, I approve the facts to false. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Unnecessary
gather_factsset to false inconfigure_aap.ymlfor better performance.How should this be tested?
manual locally tested
Is there a relevant Issue open for this?
N/A
Other Relevant info, PRs, etc
N/A