Add event_streams, credential_types to EDA dispatcher roles #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eda_configuration_dispatcher_roles was missing an entry for credential_type and event_stream
djdanielsson
requested changes
Nov 26, 2024
Collaborator
djdanielsson
left a comment
djdanielsson
left a comment
There was a problem hiding this comment.
looks like you are missing changes to the arg_spec and need a changelog fragment
Contributor
Author
|
@djdanielsson added the requested updates. I noticed there are some mismatches between the role dispatcher defaults and argument_specs unrelated to this PR. Would you like me to sync those up? (eda_user and eda_project_sync exist in argument_spec but not defaults) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds entries for eda_credential_types and eda_event_streams roles to the dispatcher configuration variable
How should this be tested?
Define entries for eda_credential_types and eda_event_streams before calling infra.aap_configuration.dispatch and ensure the resources are created in EDA.
Is there a relevant Issue open for this?
resolves #987
Other Relevant info, PRs, etc