Skip to content

Commit 6c033ec

Browse files
authored
Merge pull request #15 from remerge/fix-deprecated-secret-replication
Fix deprecated Google Cloud secret replication
2 parents 5dfa789 + 357a963 commit 6c033ec

File tree

9 files changed

+18
-15
lines changed

9 files changed

+18
-15
lines changed

.copier-answers.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
---
22
# Changes here will be overwritten by Copier
3-
_commit: v2.0.1
3+
_commit: v2.0.11-3-g8970631
44
_src_path: gh:remerge/template
55
project_id: terraform-modules
66
project_license: apache-2.0
77
project_name: Terraform Modules
88
project_owner: core
99
project_type: terraform-module
10+
run_workflows_for_all_branches: false
1011
use_python: false

.envrc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,6 @@ dotenv_if_exists
1414

1515
# Add local scripts to PATH
1616
PATH_add "${PWD}/bin"
17+
18+
# Enforce correct 1Password account
19+
export OP_ACCOUNT=remerge.1password.com

.pre-commit-config.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,14 @@ repos:
3333

3434
# https://github.com/pre-commit/mirrors-prettier/tags
3535
- repo: https://github.com/pre-commit/mirrors-prettier
36-
rev: "v3.0.0"
36+
rev: "v3.0.3"
3737
hooks:
3838
- id: prettier
3939
exclude: "^project/"
4040

4141
# https://github.com/igorshubovych/markdownlint-cli/tags
4242
- repo: https://github.com/igorshubovych/markdownlint-cli
43-
rev: "v0.35.0"
43+
rev: "v0.37.0"
4444
hooks:
4545
- id: markdownlint-fix
4646
name: markdownlint
@@ -67,14 +67,14 @@ repos:
6767

6868
# https://github.com/rhysd/actionlint/tags
6969
- repo: https://github.com/rhysd/actionlint
70-
rev: "v1.6.25"
70+
rev: "v1.6.26"
7171
hooks:
7272
- id: actionlint-docker
7373
name: actionlint
7474

7575
# https://github.com/antonbabenko/pre-commit-terraform/tags
7676
- repo: https://github.com/antonbabenko/pre-commit-terraform
77-
rev: "v1.81.0"
77+
rev: "v1.83.4"
7878
hooks:
7979
- id: terraform_fmt
8080
name: terraform-fmt
@@ -83,7 +83,7 @@ repos:
8383

8484
# https://github.com/bridgecrewio/checkov/tags
8585
- repo: https://github.com/bridgecrewio/checkov
86-
rev: "2.3.340"
86+
rev: "2.4.48"
8787
hooks:
8888
- id: checkov
8989
name: checkov

CONTRIBUTING.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,3 +36,7 @@ Most dependencies can be installed using [Homebrew](https://brew.sh):
3636
brew install --cask docker
3737
brew install pre-commit pipx direnv copier
3838
```
39+
40+
Once `pre-commit` hook is activated (`make pre-commit-install`),
41+
set of formatting and linting routines is run automatically on each commit.
42+
The step could be avoided by providing `--no-verify` flag for `git commit`.

Makefile

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,17 +82,12 @@ update:: copier-update
8282

8383
## pre-commit
8484

85-
.git/hooks/pre-commit:
86-
make pre-commit-install
87-
8885
.PHONY: pre-commit-install
8986
pre-commit-install: ## install pre-commit hook
9087
pre-commit install -t pre-commit -t prepare-commit-msg -t commit-msg
91-
install:: pre-commit-install
9288

9389
.PHONY: pre-commit-check
9490
pre-commit-check: ## run pre commit hooks
95-
pre-commit-check: .git/hooks/pre-commit
9691
pre-commit run --all-files
9792
check:: pre-commit-check
9893

google/redis/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ module "netbox-vm" {
4141
resource "google_secret_manager_secret" "auth" {
4242
secret_id = "redis-auth-${var.name}"
4343
replication {
44-
automatic = true
44+
auto {}
4545
}
4646
}
4747

google/sql/database/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ resource "google_secret_manager_secret" "user" {
2121
project = var.project
2222
secret_id = "sql-${var.instance}-user-${var.name}"
2323
replication {
24-
automatic = true
24+
auto {}
2525
}
2626
}
2727

okta/pam/project/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ resource "google_secret_manager_secret" "okta_enrollment_token" {
2020
project = var.project
2121
secret_id = "okta-enrollment-token"
2222
replication {
23-
automatic = true
23+
auto {}
2424
}
2525
}
2626

sendgrid/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ resource "google_secret_manager_secret" "key" {
1313
project = var.project
1414
secret_id = "sendgrid-key-${var.name}"
1515
replication {
16-
automatic = true
16+
auto {}
1717
}
1818
}
1919

0 commit comments

Comments
 (0)