-
Notifications
You must be signed in to change notification settings - Fork 142
Support compilation on Windows #1470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sail2
Are you sure you want to change the base?
Conversation
Test Results 16 files 36 suites 0s ⏱️ For more details on these errors, see this check. Results for commit 611ccd5. ♻️ This comment has been updated with latest results. |
|
Could try setting |
4ba8825 to
a7dec10
Compare
|
For some reason the conditional compilation does not seem to be working quite right. The interpreter is also disabled on Linux, which is why the tests are failing. |
5feceab to
30c2822
Compare
|
Ok with some more commits (not yet in this PR) I managed to make this work. Here's a release build (it's a zip within a zip because Github zips all artifacts). Needs some more work on the Also one minor issue that I think probably affects all platforms is that Mercifully Smart Screen apparently doesn't seem apply to programs run from the command line so we don't have to worry about signing or buying certificates. @edolnx FYI |
|
I think at some point the |
This also currently includes some incidental CI improvements that I made when trying to punch Github CI in the face until it worked: * Use explicit `os` versions * Use `runner.os ==` instead of `startswith(matrix.os` * Use the `setup-z3` action to set up Z3 * Use the `setup-ocaml` action. This includes caching. Also some of the tarball generation logic is moved from the Makefile into `sail_maker` (OCaml) because it's difficult to make portable Makefiles.
30c2822 to
611ccd5
Compare
|
Ok this seems to work now. Quite a lot of changes to the Github CI flows, sorry! I can probably break it down into a couple of smaller PRs if necessary (but I'd rather be lazy and not!). |
Support compilation on Windows by disabling the REPL because the
linenoiselibrary doesn't compile on Windows.This also requires manually setting
LEMLIBdue to the way OPAM works (or doesn't) on Windows.