Skip to content

Conversation

@tomiir
Copy link
Collaborator

@tomiir tomiir commented Nov 28, 2025

Description

  • remove bitcoinjs-lib from Bitcoin adapter as it was unused

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Note

Removes the unused bitcoinjs-lib from the Bitcoin adapter and updates docs to reflect Wallet Standard usage.

  • Adapters/Bitcoin:
    • Remove unused bitcoinjs-lib from packages/adapters/bitcoin/package.json.
  • Docs:
    • Update .cursor/rules/appkit-monorepo.mdc to note Bitcoin uses wallet-standard and sats-connect.
  • Release:
    • Add changeset (.changeset/strict-wombats-dress.md) for a patch bump of @reown/appkit-adapter-bitcoin.

Written by Cursor Bugbot for commit 69a3dea. This will update automatically on new commits. Configure here.

Copilot AI review requested due to automatic review settings November 28, 2025 11:29
@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2025

🦋 Changeset detected

Latest commit: 69a3dea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@reown/appkit-adapter-bitcoin Patch
@reown/appkit Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-ton Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-common Patch
@reown/appkit-universal-connector Patch
@reown/appkit-ui Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-utils Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-polyfills Patch
@reown/appkit-wallet Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-wallet-button Patch
@reown/appkit-cdn Patch
@reown/appkit-experimental Patch
@reown/appkit-testing Patch
@reown/appkit-cli Patch
@reown/appkit-pay Patch
@reown/appkit-codemod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
appkit-basic-html Ready Ready Preview Comment Nov 28, 2025 11:35am
appkit-demo Ready Ready Preview Comment Nov 28, 2025 11:35am
appkit-gallery Ready Ready Preview Comment Nov 28, 2025 11:35am
appkit-headless-sample-app Ready Ready Preview Comment Nov 28, 2025 11:35am
appkit-laboratory Ready Ready Preview Comment Nov 28, 2025 11:35am
10 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
appkit-basic-example Ignored Ignored Nov 28, 2025 11:35am
appkit-basic-sign-client-example Ignored Ignored Nov 28, 2025 11:35am
appkit-basic-up-example Ignored Ignored Nov 28, 2025 11:35am
appkit-ethers5-bera Ignored Ignored Nov 28, 2025 11:35am
appkit-nansen-demo Ignored Ignored Nov 28, 2025 11:35am
appkit-vue-solana Ignored Ignored Nov 28, 2025 11:35am
appkit-wagmi-cdn-example Ignored Ignored Nov 28, 2025 11:35am
ethereum-provider-wagmi-example Ignored Ignored Nov 28, 2025 11:35am
next-wagmi-solana-bitcoin-example Ignored Ignored Nov 28, 2025 11:35am
vue-wagmi-example Ignored Ignored Nov 28, 2025 11:35am

@socket-security
Copy link

socket-security bot commented Nov 28, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​walletconnect/​sign-client@​2.23.0100100779780

View full report

Copilot finished reviewing on behalf of tomiir November 28, 2025 11:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unused bitcoinjs-lib dependency from the Bitcoin adapter package. The dependency was declared in package.json but never imported or used in the codebase.

Key changes:

  • Removed bitcoinjs-lib version 6.1.7 from the Bitcoin adapter's dependencies
  • Updated pnpm-lock.yaml to reflect the dependency removal and resulting peer dependency resolution changes

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/adapters/bitcoin/package.json Removed unused bitcoinjs-lib dependency from the dependencies list
pnpm-lock.yaml Updated lock file to reflect removed dependency and adjusted peer dependency resolutions
.changeset/strict-wombats-dress.md Added changeset documenting the removal of the unused dependency
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tomiir tomiir enabled auto-merge November 28, 2025 11:30
@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

Visual Regression Test Results ✅ Passed

✨ No visual changes detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=471
Storybook Preview: https://6493191bf4b10fed8ca7353f-vcahfsoahm.chromatic.com/

@github-actions
Copy link
Contributor

📦 Bundle Size Check

All bundles are within size limits

📊 View detailed bundle sizes

> @reown/[email protected] size /home/runner/work/appkit/appkit


> size-limit

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         71.36 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 242 ms   on Snapdragon 410
Total time:   1.7 s
@reown/appkit/react
Size limit:   230 kB
Size:         228.29 kB with all dependencies, minified and gzipped
Loading time: 4.5 s     on slow 3G
Running time: 528 ms    on Snapdragon 410
Total time:   5 s
@reown/appkit/vue
Size limit:   80 kB
Size:         71.36 kB with all dependencies, minified and gzipped
Loading time: 1.4 s    on slow 3G
Running time: 243 ms   on Snapdragon 410
Total time:   1.7 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         209.39 kB with all dependencies, minified and gzipped
Loading time: 4.1 s     on slow 3G
Running time: 323 ms    on Snapdragon 410
Total time:   4.5 s
@reown/appkit-ui
Size limit:   500 kB
Size:         13.15 kB with all dependencies, minified and gzipped
Loading time: 257 ms   on slow 3G
Running time: 74 ms    on Snapdragon 410
Total time:   331 ms

@github-actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 79.69% 38331 / 48095
🔵 Statements 79.69% 38331 / 48095
🔵 Functions 77.3% 4107 / 5313
🔵 Branches 86.6% 9296 / 10734
File CoverageNo changed files found.
Generated in workflow #16420 for commit 69a3dea by the Vitest Coverage Report Action

@tomiir tomiir added this pull request to the merge queue Nov 28, 2025
github-merge-queue bot pushed a commit that referenced this pull request Nov 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants