-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore: remove bitcoinjs-lib from Bitcoin adapter #5368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 69a3dea The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
10 Skipped Deployments
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the unused bitcoinjs-lib dependency from the Bitcoin adapter package. The dependency was declared in package.json but never imported or used in the codebase.
Key changes:
- Removed
bitcoinjs-libversion 6.1.7 from the Bitcoin adapter's dependencies - Updated
pnpm-lock.yamlto reflect the dependency removal and resulting peer dependency resolution changes
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/adapters/bitcoin/package.json |
Removed unused bitcoinjs-lib dependency from the dependencies list |
pnpm-lock.yaml |
Updated lock file to reflect removed dependency and adjusted peer dependency resolutions |
.changeset/strict-wombats-dress.md |
Added changeset documenting the removal of the unused dependency |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Visual Regression Test Results ✅ Passed✨ No visual changes detected Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=471 |
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/[email protected] size /home/runner/work/appkit/appkit > size-limit |
Coverage Report
File CoverageNo changed files found. |
Co-authored-by: Copilot <[email protected]>
Description
Type of change
Note
Removes the unused
bitcoinjs-libfrom the Bitcoin adapter and updates docs to reflect Wallet Standard usage.bitcoinjs-libfrompackages/adapters/bitcoin/package.json..cursor/rules/appkit-monorepo.mdcto note Bitcoin useswallet-standardandsats-connect..changeset/strict-wombats-dress.md) for a patch bump of@reown/appkit-adapter-bitcoin.Written by Cursor Bugbot for commit 69a3dea. This will update automatically on new commits. Configure here.