Skip to content

Commit 32032ec

Browse files
Merge pull request #9 from ricardochaves/feature/update-pylint-260
fixed pylint + isort
2 parents a5a5a84 + 99fd81e commit 32032ec

File tree

5 files changed

+6
-48
lines changed

5 files changed

+6
-48
lines changed

.github/workflows/all-lints.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@ jobs:
88

99
steps:
1010
- uses: actions/checkout@v1
11-
- uses: ricardochaves/python-lint@v1.1.0
11+
- uses: ricardochaves/python-lint@master
1212
with:
1313
python-root-list: "tests"

.github/workflows/with-isort-5-lint.yml

Lines changed: 0 additions & 14 deletions
This file was deleted.

.github/workflows/without-isort-5-lint.yml

Lines changed: 0 additions & 14 deletions
This file was deleted.

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Container image that runs your code
2-
FROM ricardobchaves6/python-lint-image:1.2.0
2+
FROM ricardobchaves6/python-lint-image:1.3.0
33

44
# Copies your code file from your action repository to the filesystem path `/` of the container
55
COPY entrypoint.sh /entrypoint.sh

README.md

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,7 @@
11
# python-lint
22

3-
## Status
4-
53
<p align="left">
6-
<a href="https://github.com/ricardochaves/python-lint"><img alt="All lints status" src="https://github.com/ricardochaves/python-lint/workflows/all-lints/badge.svg"></a></p> <p align="left">
7-
<a href="https://github.com/ricardochaves/python-lint"><img alt="With Isort 5 status" src="https://github.com/ricardochaves/python-lint/workflows/with-isort-5-lint/badge.svg"></a></p> <p align="left">
8-
<a href="https://github.com/ricardochaves/python-lint"><img alt="Without isort 5 status" src="https://github.com/ricardochaves/python-lint/workflows/without-isort-5-lint/badge.svg"></a></p>
9-
10-
> [Pylint](https://www.pylint.org/) is not compatible with [Isort 5](https://github.com/timothycrosley/isort). So if you use all enabled lints, it fails in version 1.2.0
11-
12-
## Limitations
13-
14-
You can't use Isort 5 with Pylint.
15-
16-
If you wanna use Pylint with isort 4 use the `v1.1.0` version.
17-
18-
If you wanna use Isort 5 without pylint use the version `v1.2.0` and disable pylint
4+
<a href="https://github.com/ricardochaves/python-lint"><img alt="All lints status" src="https://github.com/ricardochaves/python-lint/workflows/all-lints/badge.svg"></a></p>
195

206
## About
217

@@ -37,15 +23,15 @@ Basic:
3723
```yml
3824
steps:
3925
- uses: actions/checkout@v1
40-
- uses: ricardochaves/python-lint@v1.2.0
26+
- uses: ricardochaves/python-lint@v1.3.0
4127
```
4228
4329
Options:
4430
4531
```yml
4632
steps:
4733
- uses: actions/checkout@v1
48-
- uses: ricardochaves/python-lint@v1.2.0
34+
- uses: ricardochaves/python-lint@v1.3.0
4935
with:
5036
python-root-list: "python_alelo tests"
5137
use-pylint: false
@@ -73,7 +59,7 @@ flake8 $(extra-flake8-options) $(python-root-list)
7359

7460
black --check $(extra-black-options) $(python-root-list)
7561

76-
mypy $(extra-mypy-options) $(python-root-list)"
62+
mypy $(extra-mypy-options) $(python-root-list)
7763

7864
isort $(extra-isort-options) $(python-root-list) -c --diff
7965
```

0 commit comments

Comments
 (0)