-
Notifications
You must be signed in to change notification settings - Fork 121
Commit 2900d94
authored
chore(deps): revert express v5 to v4.22.2 (#1176)
## High Level Overview of Change
<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
-->
Express v5 and path-to-regexp v8 introduces breaking changes that breaks
our deployments. We should revise our paths and fixes for the next
release (also add tests to ensure any issues would be known in CI). For
this release, roll express back to v4
### Context of Change
<!--
Please include the context of a change.
If a bug fix, when was the bug introduced? What was the behavior?
If a new feature, why was this architecture chosen? What were the
alternatives?
If a refactor, how is this better than the previous implementation?
If there is a design document for this feature, please link it here.
-->
See
expressjs/express#6038 (comment)
### Type of Change
<!--
Please check relevant options, delete irrelevant ones.
-->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release1 parent 780a7b5 commit 2900d94Copy full SHA for 2900d94
File tree
Expand file treeCollapse file tree
2 files changed
+332
-411
lines changedOpen diff view settings
Filter options
Expand file treeCollapse file tree
2 files changed
+332
-411
lines changedOpen diff view settings
0 commit comments