Skip to content

Commit 560004e

Browse files
authored
fix: remove BigQuery from Token page (#1153)
## High Level Overview of Change <!-- Please include a summary/list of the changes. If too broad, please consider splitting into multiple PRs. --> We are moving away from using Google Cloud for the Explorer. The Explorer is using GCP credential to query top trading pairs data from this public dataset: [GitHub - WietseWind/fetch-xrpl-transactions: Fetch (and store) all XRPL transactions (to a custom datastore)](https://github.com/WietseWind/fetch-xrpl-transactions) which has not been maintained recently. It would make sense to remove this part completely from the token page. ### Type of Change <!-- Please check relevant options, delete irrelevant ones. --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (non-breaking change that only restructures code) - [ ] Tests (You added tests for code that already exists, or your new feature included in this PR) - [ ] Documentation Updates - [ ] Translation Updates - [ ] Release ## Before / After <!-- If just refactoring / back-end changes, this can be just an in-English description of the change at a technical level. If a UI change, screenshots should be included. --> Token page will no longer contain `Top Trading Pairs` section.
1 parent 7459992 commit 560004e

File tree

15 files changed

+25
-1702
lines changed

15 files changed

+25
-1702
lines changed

.env.example

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,3 @@ VITE_DATA_URL=https://data.xrpl.org/v1/network
2828
# Whether to use ws instead of wss (boolean)
2929
# Only used locally (the deployed Explorer requires wss)
3030
VITE_INSECURE_WS=0
31-
32-
#Google Credentials for BigQuery, DO NOT COMMIT THESE
33-
GOOGLE_APP_PROJECT_ID=
34-
GOOGLE_APP_PRIVATE_KEY=
35-
GOOGLE_APP_CLIENT_EMAIL=

README.md

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -14,22 +14,6 @@ The project requires node@22. Follow installation instructions on [nodejs.org](h
1414

1515
Make sure to use npm version 8+ by running `npm install -g npm@latest` after you install Node.
1616

17-
### Google BigQuery Setup
18-
19-
This setup is required for the Tokens page of the explorer to function:
20-
21-
1. [Select or create a Cloud Platform project][projects].
22-
1. [Enable the Google BigQuery API][enable_api].
23-
1. [Set up authentication with a service account][auth]
24-
25-
Once you have completed these steps and generated the JSON key file, you must populate the following environment variables in the .env file with their corresponding values from the JSON key file:
26-
27-
```
28-
GOOGLE_APP_PROJECT_ID=your-project-id
29-
GOOGLE_APP_PRIVATE_KEY=-----BEGIN PRIVATE KEY-----\n...
30-
GOOGLE_APP_CLIENT_EMAIL=your-client-email
31-
```
32-
3317
### Copy example env
3418

3519
`cp .env.example .env`
@@ -102,7 +86,3 @@ When updating translation entires or adding new languages consult the guide [Tra
10286
- Latest news in [react blog](https://reactjs.org/blog)
10387
- [React documentation](https://reactjs.org/docs)
10488
- [How to think in react](https://reactjs.org/docs/thinking-in-react.html) and break down components
105-
106-
[enable_api]: https://console.cloud.google.com/flows/enableapi?apiid=bigquery.googleapis.com
107-
[projects]: https://console.cloud.google.com/project
108-
[auth]: https://cloud.google.com/docs/authentication/getting-started

0 commit comments

Comments
 (0)