Move eclic hack into Rust #71
Conversation
There was a problem hiding this comment.
Should this be in PAC? https://github.com/riscv-rust/gd32vf103-pac/blob/master/device.x
There was a problem hiding this comment.
Makes sense, but it still works with PAC 0.4.0.
This is the 0.5.0 upgrade: #72
and I'd like for this to come in first: riscv-rust/gd32vf103-pac#13 so I don't have to update the same code multiple times.
There was a problem hiding this comment.
From what I remember, storing multiple files with the same name to different output directories leads to a situation when linker chooses a random one, so it works as expected only with a bit of luck. I would not rely on it.
There was a problem hiding this comment.
PAC 0.4.0 doesn't have device.x at all.
There was a problem hiding this comment.
Ah, I see. Update to 0.5.0 should fix the issue then.
There was a problem hiding this comment.
Well, there's no issue with this MR. It can be merged now, and later we can upgrade to pac 0.5.0 and remove the unnecessary linker script.
2 participants
Uses inline assemly instead of a precompiled binary.
The LED is blinking next to me, so I'm almost sure I'm not imagining it.
I used the suggestion to define symbol tables in Rust from #55 (comment)
Original MR #55 . I skipped proper attribution because I'm tired, so let me know if I should attribute you as the commit author @rmsyn .
Tested using the
sleepbinary in https://codeberg.org/dcz/busbang/src/branch/intr/bb-longan . Yes, it's a mess. I will clean up if anyone actually wants to test.