Why do we need to clear messages after stopping in the NATS driver?

[shellphy]

In driver.go function Stop:

if atomic.LoadUint32(&c.listeners) > 0 {
		err := c.stream.Purge(ctx)
		if err != nil {
			c.log.Error("drain error", zap.Error(err))
		}
		c.stopCh <- struct{}{}
	}

Messages that haven't been consumed will be cleared every time the roadrunner restarts.

[rustatian]

Hey @shellphy 👋
RR restarts is not a frequent operation and Purge is usually very fast. There're no particular reasons other than free the memory.

[rustatian]

What exact problem do you have ?

[shellphy]

After I restarted RR, all messages in NATS were cleared, and that's the problem.

[rustatian]

Oh... yes, you're right. Could you please send a PR and remove that operation? I guess when working on a different drivers I mistakenly put that as a local cleanup.

[rustatian]

Fixed, will be in the next release.