Skip to content

Commit 39e5aff

Browse files
committed
Create rubocop TODO
1 parent 175b3f9 commit 39e5aff

File tree

2 files changed

+105
-21
lines changed

2 files changed

+105
-21
lines changed

.rubocop.yml

Lines changed: 16 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,11 @@
11
---
2+
inherit_from: './.rubocop_todo.yml'
23
AllCops:
34
TargetRubyVersion: 1.9
45

56
Style/HashSyntax:
67
EnforcedStyle: hash_rockets
78

8-
Metrics/LineLength:
9-
Enabled: false
10-
Metrics/AbcSize:
11-
Enabled: false
12-
Metrics/CyclomaticComplexity:
13-
Enabled: false
14-
Metrics/MethodLength:
15-
Enabled: false
16-
Metrics/PerceivedComplexity:
17-
Enabled: false
18-
Metrics/BlockLength:
19-
Enabled: false
20-
Metrics/ClassLength:
21-
Enabled: false
22-
Metrics/BlockNesting:
23-
Enabled: false
24-
259
Layout/FirstArrayElementLineBreak:
2610
Enabled: true
2711
Layout/FirstHashElementLineBreak:
@@ -42,10 +26,6 @@ Layout/MultilineHashBraceLayout:
4226
Layout/MultilineMethodDefinitionBraceLayout:
4327
EnforcedStyle: new_line
4428

45-
# TODO: tokeniser refactor
46-
Lint/AssignmentInCondition:
47-
Enabled: false
48-
4929
Style/AutoResourceCleanup:
5030
Enabled: true
5131
Style/BlockDelimiters:
@@ -77,3 +57,18 @@ Style/MethodCallWithArgsParentheses:
7757
- attr_accessor
7858
- attr_writer
7959
- source
60+
Style/MethodCalledOnDoEndBlock:
61+
Enabled: true
62+
Style/RegexpLiteral:
63+
EnforcedStyle: percent_r
64+
Style/TrailingCommaInArguments:
65+
EnforcedStyleForMultiline: comma
66+
Style/TrailingCommaInLiteral:
67+
EnforcedStyleForMultiline: comma
68+
Style/FormatStringToken:
69+
Enabled: false
70+
Style/FileName:
71+
Exclude:
72+
- 'lib/puppet-lint.rb'
73+
- 'lib/puppet-lint/tasks/puppet-lint.rb'
74+
- 'spec/puppet-lint_spec.rb'

.rubocop_todo.yml

Lines changed: 89 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,89 @@
1+
# This configuration was generated by
2+
# `rubocop --auto-gen-config`
3+
# on 2017-08-28 12:57:58 +1000 using RuboCop version 0.49.1.
4+
# The point is for the user to remove these configuration records
5+
# one by one as the offenses are removed from the code base.
6+
# Note that changes in the inspected code, or installation of new
7+
# versions of RuboCop, may require this file to be generated again.
8+
9+
# Offense count: 3
10+
# Configuration parameters: Include.
11+
# Include: **/Gemfile, **/gems.rb
12+
Bundler/DuplicatedGem:
13+
Exclude:
14+
- 'Gemfile'
15+
16+
# Offense count: 2
17+
# Cop supports --auto-correct.
18+
# Configuration parameters: Include, TreatCommentsAsGroupSeparators.
19+
# Include: **/Gemfile, **/gems.rb
20+
Bundler/OrderedGems:
21+
Exclude:
22+
- 'Gemfile'
23+
24+
# Offense count: 9
25+
# Configuration parameters: AllowSafeAssignment.
26+
Lint/AssignmentInCondition:
27+
Exclude:
28+
- 'lib/puppet-lint/lexer.rb'
29+
- 'lib/puppet-lint/plugins/check_classes/variable_scope.rb'
30+
31+
# Offense count: 52
32+
Metrics/AbcSize:
33+
Max: 153
34+
35+
# Offense count: 121
36+
# Configuration parameters: CountComments, ExcludedMethods.
37+
Metrics/BlockLength:
38+
Max: 1136
39+
40+
# Offense count: 8
41+
# Configuration parameters: CountBlocks.
42+
Metrics/BlockNesting:
43+
Max: 5
44+
45+
# Offense count: 2
46+
# Configuration parameters: CountComments.
47+
Metrics/ClassLength:
48+
Max: 383
49+
50+
# Offense count: 20
51+
Metrics/CyclomaticComplexity:
52+
Max: 26
53+
54+
# Offense count: 238
55+
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
56+
# URISchemes: http, https
57+
Metrics/LineLength:
58+
Max: 223
59+
60+
# Offense count: 65
61+
# Configuration parameters: CountComments.
62+
Metrics/MethodLength:
63+
Max: 94
64+
65+
# Offense count: 18
66+
Metrics/PerceivedComplexity:
67+
Max: 25
68+
69+
# Offense count: 1
70+
# Cop supports --auto-correct.
71+
Performance/RedundantBlockCall:
72+
Exclude:
73+
- 'lib/puppet-lint/tasks/puppet-lint.rb'
74+
75+
# Offense count: 7
76+
# Configuration parameters: EnforcedStyle, SupportedStyles.
77+
# SupportedStyles: nested, compact
78+
Style/ClassAndModuleChildren:
79+
Exclude:
80+
- 'lib/puppet-lint.rb'
81+
- 'lib/puppet-lint/bin.rb'
82+
- 'lib/puppet-lint/checkplugin.rb'
83+
- 'lib/puppet-lint/checks.rb'
84+
- 'lib/puppet-lint/data.rb'
85+
- 'lib/puppet-lint/optparser.rb'
86+
87+
# Offense count: 20
88+
Style/MultilineBlockChain:
89+
Enabled: false

0 commit comments

Comments
 (0)