Merge pull request #744 from rodjek/remove_string_monkeypatches

Remove monkeypatches to implement String#%

Author: rnelson0

lib/puppet-lint.rb

@@ -8,7 +8,6 @@
 require 'puppet-lint/data'
 require 'puppet-lint/checks'
 require 'puppet-lint/bin'
-require 'puppet-lint/monkeypatches'
 
 class PuppetLint::NoCodeError < StandardError; end
 class PuppetLint::NoFix < StandardError; end

lib/puppet-lint/monkeypatches.rb

@@ -8,18 +8,6 @@
     expect(subject.code).to_not be_nil
   end
 
-  # rubocop:disable Style/FormatString
-  it 'should have support for % with a hash' do
-    string = 'replace %{hash}' % { :hash => 'replaced' }
-    expect(string).to match('replace replaced')
-  end
-
-  it 'should not break regular % support' do
-    string = 'replace %s %s' % %w[get replaced]
-    expect(string).to match('replace get replaced')
-  end
-  # rubocop:enable Style/FormatString
-
   it 'should return empty manifest when empty one given as the input' do
     subject.code = ''
     subject.run