Skip to content

Commit 9bfe8c5

Browse files
Update all translation files and prepare for release (#35)
Complete voiceover accessibility improvements. Fixes #33
1 parent a95a014 commit 9bfe8c5

File tree

15 files changed

+16
-12
lines changed

15 files changed

+16
-12
lines changed

.gitattributes

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
*.gif filter=lfs diff=lfs merge=lfs -text
1+
*.strings diff

GMImagePickerDemo.gif

4.96 MB
Loading
2.11 KB
Binary file not shown.

src/GMImagePicker/GMGridViewController.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -582,8 +582,11 @@ public override nint GetItemsCount(UICollectionView collectionView, nint section
582582
public override void ItemSelected(UICollectionView collectionView, NSIndexPath indexPath)
583583
{
584584
var asset = (PHAsset)AssetsFetchResults[indexPath.Item];
585+
var cell = (GMGridViewCell)collectionView.CellForItem(indexPath);
586+
585587
_picker.SelectAsset(asset);
586588
_picker.NotifyAssetSelected(asset);
589+
ConfigureSelectCellAccessibilityAttributes(cell, true, null);
587590
}
588591

589592
public override bool ShouldDeselectItem(UICollectionView collectionView, NSIndexPath indexPath)
@@ -613,10 +616,8 @@ public override void ItemUnhighlighted(UICollectionView collectionView, NSIndexP
613616
public override bool ShouldSelectItem(UICollectionView collectionView, NSIndexPath indexPath)
614617
{
615618
var asset = (PHAsset)AssetsFetchResults[indexPath.Item];
616-
617619
var cell = (GMGridViewCell)collectionView.CellForItem(indexPath);
618-
ConfigureSelectCellAccessibilityAttributes(cell, true, null);
619-
620+
620621
if (!cell.IsEnabled)
621622
{
622623
return false;

src/GMImagePicker/GMImagePicker.csproj

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,15 @@
1313
<AssemblyName>GMImagePicker.Xamarin</AssemblyName>
1414
<PackOnBuild>true</PackOnBuild>
1515
<PackageId>GMImagePicker.Xamarin</PackageId>
16-
<PackageVersion>2.2.2</PackageVersion>
16+
<PackageVersion>999.999.999</PackageVersion>
1717
<Authors>Roy Cornelissen</Authors>
1818
<PackageIconUrl>https://raw.githubusercontent.com/roycornelissen/GMImagePicker.Xamarin/master/GMImagePickerIcon.png</PackageIconUrl>
1919
<PackageLicenseUrl>https://raw.githubusercontent.com/roycornelissen/GMImagePicker.Xamarin/master/LICENSE</PackageLicenseUrl>
2020
<Owners>Roy Cornelissen</Owners>
2121
<PackageProjectUrl>https://github.com/roycornelissen/GMImagePicker.Xamarin</PackageProjectUrl>
22-
<PackageReleaseNotes>[2.2.3]
22+
<PackageReleaseNotes>[2.3.0]
23+
- Fixed #33: Add voiceover hints for image selection/deselection in GMGridViewController. Thanks Seara Chen for the PR!
24+
[2.2.3]
2325
- Minor fix: replaced use of deprecated API method call
2426
- Switched to VSTS for CI builds
2527
[2.2.2]
552 Bytes
Binary file not shown.
550 Bytes
Binary file not shown.
552 Bytes
Binary file not shown.
552 Bytes
Binary file not shown.
560 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)