-
Notifications
You must be signed in to change notification settings - Fork 276
Open
Description
rp235x_hal::rom_data inconsistently accepts a u32 or a usize for size arguments:
rp-hal/rp235x-hal/src/rom_data.rs
Line 1258 in 38d28bd
| unsafe fn explicit_buy(buffer: *mut u8, buffer_size: u32) -> i32 { |
rp-hal/rp235x-hal/src/rom_data.rs
Line 1269 in 38d28bd
| unsafe fn get_uf2_target_partition(workarea_base: *mut u8, workarea_size: usize, family_id: u32, partition_out: *mut u32) -> i32 { |
The first 2 arguments to both of these are used as work area for the boot ROM. Is there a reason for this? The RP2350 datasheet just lists them as u32. I'm happy to open a PR to change them all to use usize (which is more convenient when passing a buffer's length as thing.len()).
Metadata
Metadata
Assignees
Labels
No labels