Merge pull request #1185 from Eiji7/patch-1

Fix false positive for NestedFunctionCalls

Author: rrrene

lib/credo/check/readability/nested_function_calls.ex

@@ -68,8 +68,9 @@ defmodule Credo.Check.Readability.NestedFunctionCalls do
     {nil, acc}
   end
 
-  # We don't look into @type attributes
-  defp traverse({:@, _, [{:type, _, _args}]}, acc, _issue) do
+  # We don't look into typespec attributes
+  defp traverse({:@, _, [{attr_name, _, _args}]}, acc, _issue)
+    when attr_name in ~w[callback macrocallback opaque spec type typep]a do
     {nil, acc}
   end
 

test/credo/check/readability/nested_function_calls_test.exs

@@ -10,10 +10,12 @@ defmodule Credo.Check.Readability.NestedFunctionCallsTest do
   test "it should NOT report code with no nested function calls" do
     """
     defmodule CredoSampleModule do
+      @callback callback_name :: Keyword.t(Some.remote(some_arg))
+      @macrocallback macrocallback_name :: Keyword.t(Some.remote(some_arg))
+      @spec spec_name :: Keyword.t(Some.remote(some_arg))
+      @opaque opaque_name :: Keyword.t(Some.remote(some_arg))
       @type type_name :: Keyword.t(Some.remote(some_arg))
-      def some_code(_foo) do
-        Enum.shuffle([1,2,3])
-      end
+      @typep typep_name :: Keyword.t(Some.remote(some_arg))
     end
     """
     |> to_source_file()