Skip to content

Consolidate plan sort order to ascending by rank #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2025
Merged

Consolidate plan sort order to ascending by rank #102

merged 2 commits into from
Nov 21, 2025

Conversation

Copy link
Contributor

Copilot AI commented Nov 21, 2025 •
edited
Loading

Plans on admin/conferences#show were sorted inconsistently: the Plans card used descending order while the Sponsorships section used ascending order.

Changes

  • Updated Admin::ConferencesController#show to sort plans by ascending rank (removed negation operator)
# Before
.sort_by { |plan, _cnt, _capa| -plan.rank }

# After  
.sort_by { |plan, _cnt, _capa| plan.rank }

Both sections now display plans in consistent order: Ruby (0), Platinum (1), Gold (2), Silver (3).

Original prompt

This section details on the original issue you should resolve

<issue_title>sort plans by rank on admin/conferences#show</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Sort plans by rank on admin conferences show page Consolidate plan sort order to ascending by rank Nov 21, 2025
Copilot AI requested a review from sorah November 21, 2025 08:41
Copilot finished work on behalf of sorah November 21, 2025 08:41
@sorah sorah marked this pull request as ready for review November 21, 2025 08:42
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Slowest examples

Top 10 slowest examples (6.18 seconds, 57.55% of total time)
Example Description Time in seconds
spec/jobs/create_broadcast_deliveries_job_spec.rb:42 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All status all is expected to eq [#<Sponsorship id: 1, accepted_at: "2025-11-21 08:43:05.110168000 +0000", booth_assigned: true, booth...92205000 +0000", url: "https://48.co.invalid", withdrawn_at: "2025-11-21 08:43:05.781149000 +0000">] 0.79691
spec/jobs/create_broadcast_deliveries_job_spec.rb:80 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All plan plan1 is expected to eq [#<Sponsorship id: 193, accepted_at: "2025-11-21 08:43:07.662610000 +0000", booth_assigned: true, boo...5126000 +0000", url: "https://232.co.invalid", withdrawn_at: "2025-11-21 08:43:08.140162000 +0000">] 0.61147
spec/jobs/create_broadcast_deliveries_job_spec.rb:60 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All status pending is expected to eq [#<Sponsorship id: 113, accepted_at: nil, booth_assigned: true, booth_requested: false, conference_id...pdated_at: "2025-11-21 08:43:06.849528000 +0000", url: "https://128.co.invalid", withdrawn_at: nil>] 0.60437
spec/jobs/create_broadcast_deliveries_job_spec.rb:51 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All status active is expected to eq [#<Sponsorship id: 49, accepted_at: "2025-11-21 08:43:05.866914000 +0000", booth_assigned: true, boot...updated_at: "2025-11-21 08:43:06.052663000 +0000", url: "https://64.co.invalid", withdrawn_at: nil>] 0.60152
spec/jobs/create_broadcast_deliveries_job_spec.rb:140 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All composite ja accepted exhibitors is expected to eq [#<Sponsorship id: 485, accepted_at: "2025-11-21 08:43:11.286546000 +0000", booth_assigned: true, boo...pdated_at: "2025-11-21 08:43:11.398895000 +0000", url: "https://494.co.invalid", withdrawn_at: nil>] 0.60059
spec/jobs/create_broadcast_deliveries_job_spec.rb:111 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All exhibitor yes is expected to eq [#<Sponsorship id: 337, accepted_at: "2025-11-21 08:43:09.466692000 +0000", booth_assigned: true, boo...0623000 +0000", url: "https://382.co.invalid", withdrawn_at: "2025-11-21 08:43:10.005604000 +0000">] 0.60028
spec/jobs/create_broadcast_deliveries_job_spec.rb:91 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All locale ja is expected to eq [#<Sponsorship id: 245, accepted_at: "2025-11-21 08:43:08.323790000 +0000", booth_assigned: true, boo...9789000 +0000", url: "https://288.co.invalid", withdrawn_at: "2025-11-21 08:43:08.834917000 +0000">] 0.59752
spec/jobs/create_broadcast_deliveries_job_spec.rb:100 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All locale en is expected to eq [#<Sponsorship id: 289, accepted_at: "2025-11-21 08:43:08.873442000 +0000", booth_assigned: true, boo...8138000 +0000", url: "https://332.co.invalid", withdrawn_at: "2025-11-21 08:43:09.383295000 +0000">] 0.59387
spec/jobs/create_broadcast_deliveries_job_spec.rb:69 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All status accepted is expected to eq [#<Sponsorship id: 145, accepted_at: "2025-11-21 08:43:07.072040000 +0000", booth_assigned: true, boo...pdated_at: "2025-11-21 08:43:07.256313000 +0000", url: "https://160.co.invalid", withdrawn_at: nil>] 0.59036
spec/jobs/create_broadcast_deliveries_job_spec.rb:131 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All composite ja active plan is expected to eq [#<Sponsorship id: 445, accepted_at: "2025-11-21 08:43:10.797276000 +0000", booth_assigned: true, boo...pdated_at: "2025-11-21 08:43:10.837557000 +0000", url: "https://448.co.invalid", withdrawn_at: nil>] 0.58562

@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Slowest examples

Top 10 slowest examples (6.2 seconds, 57.11% of total time)
Example Description Time in seconds
spec/jobs/create_broadcast_deliveries_job_spec.rb:42 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All status all is expected to eq [#<Sponsorship id: 1, accepted_at: "2025-11-21 08:43:05.229411000 +0000", booth_assigned: true, booth...26812000 +0000", url: "https://48.co.invalid", withdrawn_at: "2025-11-21 08:43:05.907138000 +0000">] 0.78521
spec/jobs/create_broadcast_deliveries_job_spec.rb:51 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All status active is expected to eq [#<Sponsorship id: 49, accepted_at: "2025-11-21 08:43:05.973219000 +0000", booth_assigned: true, boot...updated_at: "2025-11-21 08:43:06.159055000 +0000", url: "https://64.co.invalid", withdrawn_at: nil>] 0.61716
spec/jobs/create_broadcast_deliveries_job_spec.rb:100 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All locale en is expected to eq [#<Sponsorship id: 289, accepted_at: "2025-11-21 08:43:08.989387000 +0000", booth_assigned: true, boo...9642000 +0000", url: "https://332.co.invalid", withdrawn_at: "2025-11-21 08:43:09.504863000 +0000">] 0.60548
spec/jobs/create_broadcast_deliveries_job_spec.rb:91 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All locale ja is expected to eq [#<Sponsorship id: 245, accepted_at: "2025-11-21 08:43:08.433078000 +0000", booth_assigned: true, boo...6177000 +0000", url: "https://288.co.invalid", withdrawn_at: "2025-11-21 08:43:08.951310000 +0000">] 0.60422
spec/jobs/create_broadcast_deliveries_job_spec.rb:140 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All composite ja accepted exhibitors is expected to eq [#<Sponsorship id: 485, accepted_at: "2025-11-21 08:43:11.443482000 +0000", booth_assigned: true, boo...pdated_at: "2025-11-21 08:43:11.553978000 +0000", url: "https://494.co.invalid", withdrawn_at: nil>] 0.60382
spec/jobs/create_broadcast_deliveries_job_spec.rb:60 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All status pending is expected to eq [#<Sponsorship id: 113, accepted_at: nil, booth_assigned: true, booth_requested: false, conference_id...pdated_at: "2025-11-21 08:43:06.971090000 +0000", url: "https://128.co.invalid", withdrawn_at: nil>] 0.60268
spec/jobs/create_broadcast_deliveries_job_spec.rb:131 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All composite ja active plan is expected to eq [#<Sponsorship id: 445, accepted_at: "2025-11-21 08:43:10.940066000 +0000", booth_assigned: true, boo...pdated_at: "2025-11-21 08:43:10.980250000 +0000", url: "https://448.co.invalid", withdrawn_at: nil>] 0.60034
spec/jobs/create_broadcast_deliveries_job_spec.rb:122 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All composite ja pending plan is expected to eq [#<Sponsorship id: 405, accepted_at: nil, booth_assigned: true, booth_requested: false, conference_id...pdated_at: "2025-11-21 08:43:10.478441000 +0000", url: "https://408.co.invalid", withdrawn_at: nil>] 0.59903
spec/jobs/create_broadcast_deliveries_job_spec.rb:111 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All exhibitor yes is expected to eq [#<Sponsorship id: 337, accepted_at: "2025-11-21 08:43:09.594692000 +0000", booth_assigned: true, boo...2778000 +0000", url: "https://382.co.invalid", withdrawn_at: "2025-11-21 08:43:10.128170000 +0000">] 0.5961
spec/jobs/create_broadcast_deliveries_job_spec.rb:80 CreateBroadcastDeliveriesJob filters CreateBroadcastDeliveriesJob::Filters::All plan plan1 is expected to eq [#<Sponsorship id: 193, accepted_at: "2025-11-21 08:43:07.788227000 +0000", booth_assigned: true, boo...3995000 +0000", url: "https://232.co.invalid", withdrawn_at: "2025-11-21 08:43:08.249408000 +0000">] 0.59548

@sorah sorah merged commit 391b770 into master Nov 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sorah sorah sorah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sorah sorah

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sort plans by rank on admin/conferences#show

2 participants

@sorah