Cpanel::JSON::XS: use Types::Bool

Author: aferreira

XS.pm

@@ -2203,6 +2203,8 @@ sub allow_bigint {
     Carp::carp("allow_bigint() is obsoleted. use allow_bignum() instead.");
 }
 
+use Types::Bool qw(true false);
+
 BEGIN {
   package
     JSON::PP::Boolean;
@@ -2211,9 +2213,6 @@ BEGIN {
 
   local $^W; # silence redefine warnings. no warnings 'redefine' does not help
   &overload::import( 'overload', # workaround 5.6 reserved keyword warning
-    "0+"     => sub { ${$_[0]} },
-    "++"     => sub { $_[0] = ${$_[0]} + 1 },
-    "--"     => sub { $_[0] = ${$_[0]} - 1 },
     '""'     => sub { ${$_[0]} == 1 ? '1' : '0' }, # GH 29
     'eq'     => sub {
       my ($obj, $op) = ref ($_[0]) ? ($_[0], $_[1]) : ($_[1], $_[0]);
@@ -2231,30 +2230,12 @@ BEGIN {
     fallback => 1);
 }
 
-our ($true, $false);
-BEGIN {
-  if ($INC{'JSON/XS.pm'}
-      and $INC{'Types/Serialiser.pm'}
-      and $JSON::XS::VERSION ge "3.00") {
-    $true  = $Types::Serialiser::true; # readonly if loaded by JSON::XS
-    $false = $Types::Serialiser::false;
-  } else {
-    $true  = do { bless \(my $dummy = 1), "JSON::PP::Boolean" };
-    $false = do { bless \(my $dummy = 0), "JSON::PP::Boolean" };
-  }
-}
-
-BEGIN {
-  my $const_true  = $true;
-  my $const_false = $false;
-  *true  = sub () { $const_true  };
-  *false = sub () { $const_false };
-}
+our ($true, $false) = (true, false);
 
 sub is_bool($) {
   shift if @_ == 2; # as method call
   (ref($_[0]) and UNIVERSAL::isa( $_[0], JSON::PP::Boolean::))
-  or (exists $INC{'Types/Serialiser.pm'} and Types::Serialiser::is_bool($_[0]))
+  or Types::Bool::is_bool($_[0])
 }
 
 XSLoader::load 'Cpanel::JSON::XS', $XS_VERSION;