[Bug]: Corrupt deflate stream error

[solomoncyj]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

> Package identifier xd.etheria
> Package version 0.0.2
> 1st Installer URL https://website.xdcdn.net/launcher/etheria/311302-ob/EtheriaRestart_setup_0.0.2.exe
? 2nd Installer URL <canceled>
DEBUG komac::file_analyser: pe.version_info={"LegalCopyright": "©2003-2023 心动 All Rights Reserved", "FileVersion": "0.0.0.2", "ProductName": "Etheria Restart", "ProductVersion": "0.0.0.2", "FileDescription": "Etheria Restart", "CompanyName": "心动", "InternalName": "EtheriaRestart.exe"}
DEBUG komac::installers::nsis: first_header_offset=209920 first_header=FirstHeader { flags: HeaderFlags(80), magic: DeadBeef, signature: NullsoftInst, length_of_header: 344816, length_of_following_data: 95876853 }
DEBUG komac::installers::nsis::header: compression=Zlib
Error:
   0: corrupt deflate stream

  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ BACKTRACE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
                                ⋮ 10 frames hidden ⋮
  11: core::convert::impl$3::into<enum2$<komac::installers::nsis::NsisError>,eyre::Report><unknown>
      at /rustc/6f69710780d579b180ab38da4c1384d630f7bd31\library\core\src\convert\mod.rs:767
  12: komac::file_analyser::FileAnalyser::new<unknown>
      at C:\Users\solom\Downloads\Komac\src\file_analyser.rs:106
  13: komac::download_file::process_files::async_fn$0::closure$0::async_block$0<unknown>
      at C:\Users\solom\Downloads\Komac\src\download_file.rs:22
  14: futures_util::stream::futures_unordered::impl$7::poll_next<enum2$<komac::download_file::process_files::async_fn$0::closure$0::async_block_env$0> ><unknown>
      at C:\Users\solom\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\futures-util-0.3.31\src\stream\futures_unordered\mod.rs:528
  15: futures_util::stream::stream::StreamExt::poll_next_unpin<futures_util::stream::futures_unordered::FuturesUnordered<enum2$<komac::download_file::process_files::async_fn$0::closure$0::async_block_env$0> > ><unknown>
      at C:\Users\solom\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\futures-util-0.3.31\src\stream\stream\mod.rs:1638
  16: futures_util::stream::stream::buffer_unordered::impl$2::poll_next<futures_util::stream::iter::Iter<core::iter::adapters::map::Map<core::slice::iter::IterMut<komac::download::file::DownloadedFile>,komac::download_file::process_files::async_fn$0::closure_env<unknown>
      at C:\Users\solom\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\futures-util-0.3.31\src\stream\stream\buffer_unordered.rs:75
  17: futures_core::stream::impl$4::try_poll_next<futures_util::stream::stream::buffer_unordered::BufferUnordered<futures_util::stream::iter::Iter<core::iter::adapters::map::Map<core::slice::iter::IterMut<komac::download::file::DownloadedFile>,komac::download_fi<unknown>
      at C:\Users\solom\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\futures-core-0.3.31\src\stream.rs:206
  18: futures_util::stream::try_stream::try_collect::impl$2::poll<futures_util::stream::stream::buffer_unordered::BufferUnordered<futures_util::stream::iter::Iter<core::iter::adapters::map::Map<core::slice::iter::IterMut<komac::download::file::DownloadedFile>,ko<unknown>
      at C:\Users\solom\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\futures-util-0.3.31\src\stream\try_stream\try_collect.rs:46
  19: komac::download_file::process_files::async_fn$0<unknown>
      at C:\Users\solom\Downloads\Komac\src\download_file.rs:41
  20: komac::commands::new_version::impl$0::run::async_fn$0<unknown>
      at C:\Users\solom\Downloads\Komac\src\commands\new_version.rs:238
  21: komac::main::async_block$0<unknown>
      at C:\Users\solom\Downloads\Komac\src\main.rs:63
  22: core::future::future::impl$1::poll<alloc::boxed::Box<enum2$<komac::main::async_block_env$0>,alloc::alloc::Global> ><unknown>
      at /rustc/6f69710780d579b180ab38da4c1384d630f7bd31\library\core\src\future\future.rs:124
  23: tokio::runtime::park::impl$4::block_on::closure$0<core::pin::Pin<alloc::boxed::Box<enum2$<komac::main::async_block_env$0>,alloc::alloc::Global> > ><unknown>
      at C:\Users\solom\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\tokio-1.45.1\src\runtime\park.rs:284
  24: tokio::task::coop::with_budget<unknown>
      at C:\Users\solom\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\tokio-1.45.1\src\task\coop\mod.rs:167
  25: tokio::task::coop::budget<unknown>
      at C:\Users\solom\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\tokio-1.45.1\src\task\coop\mod.rs:133
  26: tokio::runtime::park::CachedParkThread::block_on<core::pin::Pin<alloc::boxed::Box<enum2$<komac::main::async_block_env$0>,alloc::alloc::Global> > ><unknown>
      at C:\Users\solom\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\tokio-1.45.1\src\runtime\park.rs:284
  27: tokio::runtime::context::blocking::BlockingRegionGuard::block_on<core::pin::Pin<alloc::boxed::Box<enum2$<komac::main::async_block_env$0>,alloc::alloc::Global> > ><unknown>
      at C:\Users\solom\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\tokio-1.45.1\src\runtime\context\blocking.rs:66
  28: tokio::runtime::scheduler::multi_thread::impl$0::block_on::closure$0<core::pin::Pin<alloc::boxed::Box<enum2$<komac::main::async_block_env$0>,alloc::alloc::Global> > ><unknown>
      at C:\Users\solom\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\tokio-1.45.1\src\runtime\scheduler\multi_thread\mod.rs:87
  29: tokio::runtime::context::runtime::enter_runtime<tokio::runtime::scheduler::multi_thread::impl$0::block_on::closure_env$0<core::pin::Pin<alloc::boxed::Box<enum2$<komac::main::async_block_env$0>,alloc::alloc::Global> > >,enum2$<core::result::Result<tuple$<>,<unknown>
      at C:\Users\solom\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\tokio-1.45.1\src\runtime\context\runtime.rs:65
  30: tokio::runtime::scheduler::multi_thread::MultiThread::block_on<core::pin::Pin<alloc::boxed::Box<enum2$<komac::main::async_block_env$0>,alloc::alloc::Global> > ><unknown>
      at C:\Users\solom\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\tokio-1.45.1\src\runtime\scheduler\multi_thread\mod.rs:86
  31: tokio::runtime::runtime::Runtime::block_on_inner<core::pin::Pin<alloc::boxed::Box<enum2$<komac::main::async_block_env$0>,alloc::alloc::Global> > ><unknown>
      at C:\Users\solom\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\tokio-1.45.1\src\runtime\runtime.rs:358
  32: tokio::runtime::runtime::Runtime::block_on<enum2$<komac::main::async_block_env$0> ><unknown>
      at C:\Users\solom\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\tokio-1.45.1\src\runtime\runtime.rs:328
  33: komac::main<unknown>
      at C:\Users\solom\Downloads\Komac\src\main.rs:62
  34: core::ops::function::FnOnce::call_once<enum2$<core::result::Result<tuple$<>,eyre::Report> > (*)(),tuple$<> ><unknown>
      at /rustc/6f69710780d579b180ab38da4c1384d630f7bd31\library\core\src\ops\function.rs:250
  35: std::sys::backtrace::__rust_begin_short_backtrace<enum2$<core::result::Result<tuple$<>,eyre::Report> > (*)(),enum2$<core::result::Result<tuple$<>,eyre::Report> > ><unknown>
      at /rustc/6f69710780d579b180ab38da4c1384d630f7bd31\library\std\src\sys\backtrace.rs:152
                                ⋮ 12 frames hidden ⋮
error: process didn't exit successfully: `target\debug\komac.exe new` (exit code: 1)

[russellbanks]

I've spent a while looking into this and I can't figure out how 7-Zip is able to extract the installer. 7-Zip says the installer is a 7Zip installer compressed using Lzma, but after looking at the header and checking how 7-Zip determines the compression, I can't see how it comes to that conclusion. From 7-Zip's own code, which komac models extracts from, it should be Zlib.

This comment serves more as a note for future investigation.