[Bug]: Failed to fill whole buffer for Inno installer (again)

[KarbitsCode]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

Similar to #1070, this specific package also affected this issue: iTop.DualSafePasswordManager

Reproduce:

komac update iTop.DualSafePasswordManager --version 1.4.0.14 --urls "https://download.itopupdate.com/dl/dualsafe-password-manager-setup.exe"

Screenshot:

[LinXP]

C:\Users>komac -v
komac 2.13.0

C:\Users>komac update Havysoft.InnoExtractor -v 11.1.0.153 -u https://www.havysoft.cl/download/IE_Install.zip
Latest version of Havysoft.InnoExtractor: 11.1.0.152
Error:
   0: failed to fill whole buffer

IE_Install.exe info:

PE32
    Operation system: Windows (2000) [I386, 32-bit, GUI]
    Linker: Turbo Linker
    Compiler: Embarcadero Delphi (2009-2010) [Enterprise]
    Language: Object Pascal (Delphi)
    (Heur) Packer: Compressed data [Strange overlay + Recurring import names]
    Installer: Inno Setup Module (5.5.7) [unicode]
    Overlay: Binary[Offset = 0x0002a200, Size = 0x013b3bb4]
        Data: Inno Setup Installer data

[LinXP]

more links with this error:

https://files.vovsoft.com/3d-box-maker.exe
https://files.vovsoft.com/auto-change-wallpapers.exe
https://files.vovsoft.com/blur-multiple-images.exe
https://files.vovsoft.com/burn-studio.exe
https://files.vovsoft.com/compare-two-lists.exe

[KarbitsCode]

I found another one: Ziad.TCG (though it's kind of different from the issue title)

Reproduce:

komac update Ziad.TCG --version 8.0-stable --urls "https://sourceforge.net/projects/temp-cleaner-gui/files/v8.0-stable/temp_cleaner_gui_v8.0-stable_amd64_win7sp1to11_mrx.exe" "https://sourceforge.net/projects/temp-cleaner-gui/files/v8.0-stable/temp_cleaner_gui_v8.0-stable_x86_win8to10_mrx.exe"

Screenshot:

Edit: I just noticed that this package uses inno setup, don't know why the komac thinks it's nsis.

[russellbanks]

I found another one: Ziad.TCG (though it's kind of different from the issue title)

Are you running the latest version of komac? I've tried this locally and it works as expected:

komac analyse temp_cleaner_gui_v8.0-stable_amd64_win7sp1to11_mrx.exe

InstallerLocale: en-US
Architecture: x86
InstallerType: inno
Scope: machine
InstallerUrl: https://example.com/
InstallerSha256: '0000000000000000000000000000000000000000000000000000000000000000'
ProductCode: '{6082CDBD-AE3B-4548-A1A8-F8BCE21EFC81}_is1'
AppsAndFeaturesEntries:
- DisplayName: Temp_Cleaner GUI
  Publisher: Ziad (Mr.X)'s Software
  DisplayVersion: 8.0-stable
  ProductCode: '{6082CDBD-AE3B-4548-A1A8-F8BCE21EFC81}_is1'
ElevationRequirement: elevatesSelf
InstallationMetadata:
  DefaultInstallLocation: '%ProgramFiles%\Temp_Cleaner GUI'

[UnownPlain]

Are you running the latest version of komac? I've tried this locally and it works as expected:

This seems to happen when using the update command and not the analyze command.

[russellbanks]

Are you running the latest version of komac? I've tried this locally and it works as expected:

This seems to happen when using the update command and not the analyze command.

Ah, thank you for spotting that. The cause of this is that the link goes to the sourceforge page that has you wait 5 seconds before the download so komac actually ends up downloading that intermediate HTML page. The correct link to use would be the url + /download which then does work correctly. I'll add some validation to this to check that we're downloading an octet-stream and fix the URL to have /download if it's been provided without.

[UnownPlain]

I'll add some validation to this to check that we're downloading an octet-stream

That will break downloads from servers that send down other content types like application/x-msdos-program, application/x-msdownload, application/x-ms-dos-executable, application/vnd.microsoft.portable-executable, application/zip, application/msix, etc.

[russellbanks]

I'll add some validation to this to check that we're downloading an octet-stream

That will break downloads from servers that send down other content types like application/x-msdos-program, application/x-msdownload, application/x-ms-dos-executable, application/vnd.microsoft.portable-executable, application/zip, application/msix, etc.

Thank you. I'll check instead if the content type starts with application as that at least prevents downloading HTML pages, etc.

[KarbitsCode]

The cause of this is that the link goes to the sourceforge page that has you wait 5 seconds before the download so komac actually ends up downloading that intermediate HTML page. The correct link to use would be the url + /download which then does work correctly.

I don't think that's related though, winget, wingetcreate and curl still works fine and not downloading the HTML page even without that /download endpoint, maybe they're using checking user agent to determine whether it's giving the direct download link or redirection page

[LinXP]

failed to fill whole buffer:
https://download.advanced-port-scanner.com/download/files/Advanced_Port_Scanner_2.5.3869.exe