Use riscv_pac::CoreInterrupt in sie register

Author: romancardenas

riscv/CHANGELOG.md

@@ -10,8 +10,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Added
 
 - New convenience  `try_new` and `new` associated functions for `Mtvec` and `Stvec`.
-- New methods and functions for enabling core interrupts in the `mie` register using
-  the `riscv_pac::CoreInterrupt` trait.
+- New methods and functions for enabling core interrupts in the `mie` and `sie` registers
+  using the `riscv_pac::CoreInterrupt` trait.
+- New `riscv::interrupt::{disable_interrupt, enable_interrupt}` functions.
 
 ### Changed
 

riscv/src/interrupt/machine.rs

@@ -1,6 +1,6 @@
 use crate::{
     interrupt::Trap,
-    register::{mcause, mepc, mstatus},
+    register::{mcause, mepc, mie, mstatus},
 };
 use riscv_pac::{
     result::{Error, Result},
@@ -96,18 +96,42 @@ unsafe impl ExceptionNumber for Exception {
     }
 }
 
-/// Disables all interrupts in the current hart (machine mode).
+/// Disables interrupts for a specific core interrupt source in the current hart (machine mode).
+#[inline]
+pub fn disable_interrupt<I: CoreInterruptNumber>(interrupt: I) {
+    // SAFETY: it is safe to disable an interrupt source
+    mie::disable_interrupt(interrupt);
+}
+
+/// Enables interrupts for a specific core interrupt source in the current hart (machine mode).
+///
+/// # Note
+///
+/// Interrupts will only be triggered if interrupts are globally enabled in the hart.
+/// To do this, you must call [`enable`]  after enabling the interrupt.
+///
+/// # Safety
+///
+/// Enabling interrupts might break critical sections or other synchronization mechanisms.
+/// Ensure that this is called in a safe context where interrupts can be enabled.
+#[inline]
+pub unsafe fn enable_interrupt<I: CoreInterruptNumber>(interrupt: I) {
+    mie::enable_interrupt(interrupt);
+}
+
+/// Disables interrupts globally in the current hart (machine mode).
 #[inline]
 pub fn disable() {
     // SAFETY: It is safe to disable interrupts
     unsafe { mstatus::clear_mie() }
 }
 
-/// Enables all the interrupts in the current hart (machine mode).
+/// Enables interrupts globally in the current hart (machine mode).
 ///
 /// # Safety
 ///
-/// Do not call this function inside a critical section.
+/// Enabling interrupts might break critical sections or other synchronization mechanisms.
+/// Ensure that this is called in a safe context where interrupts can be enabled.
 #[inline]
 pub unsafe fn enable() {
     mstatus::set_mie()

riscv/src/interrupt/supervisor.rs

@@ -1,6 +1,6 @@
 use crate::{
     interrupt::Trap,
-    register::{scause, sepc, sstatus},
+    register::{scause, sepc, sie, sstatus},
 };
 use riscv_pac::{
     result::{Error, Result},
@@ -88,18 +88,42 @@ unsafe impl ExceptionNumber for Exception {
     }
 }
 
-/// Disables all interrupts in the current hart (supervisor mode).
+/// Disables interrupts for a specific core interrupt source in the current hart (supervisor mode).
+#[inline]
+pub fn disable_interrupt<I: CoreInterruptNumber>(interrupt: I) {
+    // SAFETY: it is safe to disable an interrupt source
+    sie::disable_interrupt(interrupt);
+}
+
+/// Enables interrupts for a specific core interrupt source in the current hart (supervisor mode).
+///
+/// # Note
+///
+/// Interrupts will only be triggered if interrupts are globally enabled in the hart.
+/// To do this, you must call [`enable`]  after enabling the interrupt.
+///
+/// # Safety
+///
+/// Enabling interrupts might break critical sections or other synchronization mechanisms.
+/// Ensure that this is called in a safe context where interrupts can be enabled.
+#[inline]
+pub unsafe fn enable_interrupt<I: CoreInterruptNumber>(interrupt: I) {
+    sie::enable_interrupt(interrupt);
+}
+
+/// Disables interrupts globally in the current hart (supervisor mode).
 #[inline]
 pub fn disable() {
     // SAFETY: It is safe to disable interrupts
     unsafe { sstatus::clear_sie() }
 }
 
-/// Enables all the interrupts in the current hart (supervisor mode).
+/// Enables interrupts globally in the current hart (supervisor mode).
 ///
 /// # Safety
 ///
-/// Do not call this function inside a critical section.
+/// Enabling interrupts might break critical sections or other synchronization mechanisms.
+/// Ensure that this is called in a safe context where interrupts can be enabled.
 #[inline]
 pub unsafe fn enable() {
     sstatus::set_sie()

riscv/src/register/mie.rs

@@ -88,7 +88,7 @@ set_clear_csr!(
 
 /// Disables a specific core interrupt source.
 #[inline]
-pub fn clear_interrupt<I: CoreInterruptNumber>(interrupt: I) {
+pub fn disable_interrupt<I: CoreInterruptNumber>(interrupt: I) {
     // SAFETY: it is safe to disable an interrupt source
     unsafe { _clear(1 << interrupt.number()) };
 }
@@ -100,7 +100,7 @@ pub fn clear_interrupt<I: CoreInterruptNumber>(interrupt: I) {
 /// Enabling interrupts might break critical sections or other synchronization mechanisms.
 /// Ensure that this is called in a safe context where interrupts can be enabled.
 #[inline]
-pub unsafe fn set_interrupt<I: CoreInterruptNumber>(interrupt: I) {
+pub unsafe fn enable_interrupt<I: CoreInterruptNumber>(interrupt: I) {
     unsafe { _set(1 << interrupt.number()) };
 }
 

riscv/src/register/sie.rs

@@ -1,9 +1,11 @@
 //! sie register
 
+use riscv_pac::CoreInterruptNumber;
+
 read_write_csr! {
 /// sie register
     Sie: 0x104,
-    mask: 0x222,
+    mask: usize::MAX,
 }
 
 read_write_csr_field! {
@@ -24,6 +26,26 @@ read_write_csr_field! {
     sext: 9,
 }
 
+impl Sie {
+    /// Check if a specific core interrupt source is enabled.
+    #[inline]
+    pub fn is_enabled<I: CoreInterruptNumber>(&self, interrupt: I) -> bool {
+        (self.bits & (1 << interrupt.number())) != 0
+    }
+
+    /// Enable a specific core interrupt source.
+    #[inline]
+    pub fn enable<I: CoreInterruptNumber>(&mut self, interrupt: I) {
+        self.bits |= 1 << interrupt.number();
+    }
+
+    /// Disable a specific core interrupt source.
+    #[inline]
+    pub fn disable<I: CoreInterruptNumber>(&mut self, interrupt: I) {
+        self.bits &= !(1 << interrupt.number());
+    }
+}
+
 set!(0x104);
 clear!(0x104);
 
@@ -37,9 +59,28 @@ set_clear_csr!(
     /// Supervisor External Interrupt Enable
     , set_sext, clear_sext, 1 << 9);
 
+/// Disables a specific core interrupt source.
+#[inline]
+pub fn disable_interrupt<I: CoreInterruptNumber>(interrupt: I) {
+    // SAFETY: it is safe to disable an interrupt source
+    unsafe { _clear(1 << interrupt.number()) };
+}
+
+/// Enables a specific core interrupt source.
+///
+/// # Safety
+///
+/// Enabling interrupts might break critical sections or other synchronization mechanisms.
+/// Ensure that this is called in a safe context where interrupts can be enabled.
+#[inline]
+pub unsafe fn enable_interrupt<I: CoreInterruptNumber>(interrupt: I) {
+    unsafe { _set(1 << interrupt.number()) };
+}
+
 #[cfg(test)]
 mod tests {
     use super::*;
+    use crate::interrupt::supervisor::Interrupt;
 
     #[test]
     fn test_sie() {
@@ -49,4 +90,24 @@ mod tests {
         test_csr_field!(sie, stimer);
         test_csr_field!(sie, sext);
     }
+
+    #[test]
+    fn test_sie_interrupt() {
+        let mut s = Sie::from_bits(0);
+
+        s.enable(Interrupt::SupervisorSoft);
+        assert!(s.is_enabled(Interrupt::SupervisorSoft));
+        s.disable(Interrupt::SupervisorSoft);
+        assert!(!s.is_enabled(Interrupt::SupervisorSoft));
+
+        s.enable(Interrupt::SupervisorTimer);
+        assert!(s.is_enabled(Interrupt::SupervisorTimer));
+        s.disable(Interrupt::SupervisorTimer);
+        assert!(!s.is_enabled(Interrupt::SupervisorTimer));
+
+        s.enable(Interrupt::SupervisorExternal);
+        assert!(s.is_enabled(Interrupt::SupervisorExternal));
+        s.disable(Interrupt::SupervisorExternal);
+        assert!(!s.is_enabled(Interrupt::SupervisorExternal));
+    }
 }