riscv: Confusion regarding `pac_enum` documentation

[kurtjd]

The documentation for the pac_enum macro states:

/// The trait name must be one of `ExceptionNumber`, `InterruptNumber`, `PriorityNumber`, or `HartIdNumber`.
/// Marker traits `CoreInterruptNumber` and `ExternalInterruptNumber` cannot be implemented using this macro.

However we see here in the riscv-peripheral crate example this macro being used for ExternalInterruptNumber and additionally svd2rust generates code using this enum for CoreInterruptNumber.

Was hoping to understand if this is simply outdated info in the documentation that should be updated or if there is some other context I am missing. Thank you!

[romancardenas]

You are right! The docs are outdated. It should be:

/// The trait name must be one of `ExceptionNumber`, `CoreInterruptNumber `, `ExternalInterruptNumber `, `PriorityNumber`, or `HartIdNumber`.

[romancardenas]

Closing as complete by #345

[kurtjd]

Awesome, thank you! Much appreciated.

[ejd]

@romancardenas I ran into the issue that #345 fixes in one of my projects. I'm curious to know whether (or when) you'd consider cutting a new release that integrates the fixes in #345. I'm using a git dependency in the meantime.

[kurtjd]

Same, I'm using git dependency for now as well and a new release would be nice (but no rush!)

[romancardenas]

I would like to merge at least #375. I will try to speed up the process. Thanks for your comments!

[ejd]

Thank you!