Add docs for json feature, make frontend error pub #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Build all features on docs.rs - Add a `docsrs` cfg attr and add to items that are public but only when the json feature is enabled - Make the `JsonFrontendError` type nameable, this type is referred to in a public variant of `Error` but was not accessible outside the crate. Signed-off-by: Ross MacArthur <[email protected]>
rossmacarthur
force-pushed
the
feature-docs
branch
from
0ed48dd to
50c2044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
docsrscfg attr and add to items that are public but only when the json feature is enabledJsonFrontendErrortype nameable, this type is referred to in a public variant ofErrorbut was not accessible outside the crate.Screenshots
index
Error
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.