Skip to content

[WIP] Global stmt variable #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[WIP] Global stmt variable #29

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
203b7dc
sqlclosecheck crashes when sql.Stmt is stored in global var. Add test…
TelpeNight Mar 30, 2023
6dba03f
Merge branch 'main' into global_var
ryanrolds Aug 27, 2023
91f8911
Whitespace
ryanrolds Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions pkg/analyzer/testdata/stmt/global_var.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
package stmt

import (
"database/sql"
"math/rand"
"sync"
)

var (
globalOnce sync.Once
globalStmt *sql.Stmt
globalErr error
)

func globalVarTest() {
defer func() {
if globalStmt != nil {
_ = globalStmt.Close()
}
}()

for i := 0; i < 100; i++ {
if rand.Float64() > 0.8 {
err := optionalDbOp()
if err != nil {
return
}
}
}
}

func optionalDbOp() error {
globalOnce.Do(func() {
globalStmt, globalErr = db.Prepare("INSERT INTO `test` (`id`) VALUES(1)")
})
if globalErr != nil {
return globalErr
}

_, err := globalStmt.Exec()
return err
}