ref #6 Only allow either comma or semicolon for a field delimiter

Author: ryu1kn

lib/csv-stringifier-factory.js

@@ -4,12 +4,15 @@
 const ArrayCsvStringifier = require('./csv-stringifiers/array');
 const FieldStringifier = require('./field-stringifier');
 const ObjectCsvStringifier = require('./csv-stringifiers/object');
+
 const DEFAULT_FIELD_DELIMITER = ',';
+const VALID_FIELD_DELIMITERS = [DEFAULT_FIELD_DELIMITER, ';'];
 
 class CsvStringifierFactory {
 
     createArrayCsvStringifier(params) {
         const fieldDelimiter = params.fieldDelimiter || DEFAULT_FIELD_DELIMITER;
+        _validateFieldDelimiter(fieldDelimiter);
         return new ArrayCsvStringifier({
             fieldStringifier: new FieldStringifier({fieldDelimiter}),
             fieldDelimiter,
@@ -19,6 +22,7 @@ class CsvStringifierFactory {
 
     createObjectCsvStringifier(params) {
         const fieldDelimiter = params.fieldDelimiter || DEFAULT_FIELD_DELIMITER;
+        _validateFieldDelimiter(fieldDelimiter);
         return new ObjectCsvStringifier({
             fieldStringifier: new FieldStringifier({fieldDelimiter}),
             fieldDelimiter,
@@ -28,4 +32,10 @@ class CsvStringifierFactory {
 
 }
 
+function _validateFieldDelimiter(delimiter) {
+    if (VALID_FIELD_DELIMITERS.indexOf(delimiter) === -1) {
+        throw new Error(`Invalid field delimiter \`${delimiter}\` is specified`);
+    }
+}
+
 module.exports = CsvStringifierFactory;

test/unit/csv-stringifiers/array.test.js

@@ -1,4 +1,3 @@
-
 const assert = require('assert');
 const resolveDelimiterChar = require('../helper/delimiter').resolveDelimiterChar;
 const createArrayCsvStringifier = require('../../../index').createArrayCsvStringifier;
@@ -13,6 +12,14 @@ describe('ArrayCsvStringifier', () => {
 
     describe('When field delimiter is semicolon', generateTestCases(';'));
 
+    describe('When field delimiter is neither comma nor semicolon', () => {
+        it('throws an exception', () => {
+            assert.throws(() => {
+                createArrayCsvStringifier({fieldDelimiter: '/'});
+            });
+        });
+    });
+
     function generateTestCases(fieldDelimiter) {
         const delim = resolveDelimiterChar(fieldDelimiter);
         return () => {

test/unit/csv-stringifiers/object.test.js

@@ -1,4 +1,3 @@
-
 const assert = require('assert');
 const resolveDelimiterChar = require('../helper/delimiter').resolveDelimiterChar;
 const createObjectCsvStringifier = require('../../../index').createObjectCsvStringifier;
@@ -13,6 +12,17 @@ describe('ObjectCsvStringifier', () => {
 
     describe('When field delimiter is semicolon', generateTestCases(';'));
 
+    describe('When field delimiter is neither comma nor semicolon', () => {
+        it('throws an exception', () => {
+            assert.throws(() => {
+                createObjectCsvStringifier({
+                    header: ['FIELD_A', 'FIELD_B'],
+                    fieldDelimiter: '/'
+                });
+            });
+        });
+    });
+
     function generateTestCases(fieldDelimiter) {
         const delim = resolveDelimiterChar(fieldDelimiter);
         return () => {