add unit tests

Author: sam-mfb

src/core/controls/blankControls.test.ts

@@ -0,0 +1,102 @@
+/**
+ * @fileoverview Tests for blankControls utility
+ */
+
+import { describe, it, expect } from 'vitest'
+import { blankControls } from './blankControls'
+
+describe('blankControls', () => {
+  it('creates blank controls with all values false', () => {
+    const source = {
+      a: true,
+      b: true,
+      c: true
+    }
+
+    const result = blankControls(source)
+
+    expect(result).toEqual({
+      a: false,
+      b: false,
+      c: false
+    })
+  })
+
+  it('preserves keys from source regardless of their values', () => {
+    const source = {
+      foo: false,
+      bar: false,
+      baz: false
+    }
+
+    const result = blankControls(source)
+
+    expect(result).toEqual({
+      foo: false,
+      bar: false,
+      baz: false
+    })
+  })
+
+  it('applies overrides to specific controls', () => {
+    const source = {
+      a: true,
+      b: true,
+      c: true
+    }
+
+    const result = blankControls(source, { b: true })
+
+    expect(result).toEqual({
+      a: false,
+      b: true,
+      c: false
+    })
+  })
+
+  it('applies multiple overrides', () => {
+    const source = {
+      x: true,
+      y: true,
+      z: true
+    }
+
+    const result = blankControls(source, { x: true, z: true })
+
+    expect(result).toEqual({
+      x: true,
+      y: false,
+      z: true
+    })
+  })
+
+  it('works with no overrides', () => {
+    const source = {
+      thrust: true,
+      fire: true,
+      shield: true
+    }
+
+    const result = blankControls(source, {})
+
+    expect(result).toEqual({
+      thrust: false,
+      fire: false,
+      shield: false
+    })
+  })
+
+  it('handles source with different property names', () => {
+    const source = {
+      propA: true,
+      propB: false,
+      propC: true
+    }
+
+    const result = blankControls(source, { propC: true })
+
+    expect(result.propA).toBe(false)
+    expect(result.propB).toBe(false)
+    expect(result.propC).toBe(true)
+  })
+})

src/core/controls/blankControls.ts

@@ -2,8 +2,6 @@
  * @fileoverview Utility for creating blank control matrices
  */
 
-import type { ControlMatrix } from './types'
-
 /**
  * Creates a blank control matrix with all controls set to false.
  * Optionally allows specific controls to be overridden.
@@ -12,16 +10,16 @@ import type { ControlMatrix } from './types'
  * @param overrides - Optional partial control matrix to override specific controls
  * @returns A complete control matrix with all controls false except overrides
  */
-export function blankControls(
-  source: ControlMatrix,
-  overrides?: Partial<ControlMatrix>
-): ControlMatrix {
-  const blank = {} as ControlMatrix
-  const keys = Object.keys(source) as (keyof ControlMatrix)[]
+export function blankControls<T extends Record<string, boolean>>(
+  source: T,
+  overrides?: Partial<T>
+): T {
+  const blank = {} as T
+  const keys = Object.keys(source) as (keyof T)[]
 
   // Set all controls to false
   for (const key of keys) {
-    blank[key] = overrides?.[key] ?? false
+    blank[key] = (overrides?.[key] ?? false) as T[keyof T]
   }
 
   return blank

src/core/controls/mergeControls.test.ts

@@ -0,0 +1,120 @@
+/**
+ * @fileoverview Tests for mergeControls utility
+ */
+
+import { describe, it, expect } from 'vitest'
+import { mergeControls } from './mergeControls'
+
+describe('mergeControls', () => {
+  it('merges two control sets with OR logic', () => {
+    const controls1 = {
+      a: true,
+      b: false,
+      c: true
+    }
+
+    const controls2 = {
+      a: false,
+      b: true,
+      c: true
+    }
+
+    const result = mergeControls(controls1, controls2)
+
+    expect(result).toEqual({
+      a: true, // true OR false = true
+      b: true, // false OR true = true
+      c: true // true OR true = true
+    })
+  })
+
+  it('handles all false controls', () => {
+    const controls1 = {
+      x: false,
+      y: false,
+      z: false
+    }
+
+    const controls2 = {
+      x: false,
+      y: false,
+      z: false
+    }
+
+    const result = mergeControls(controls1, controls2)
+
+    expect(result).toEqual({
+      x: false,
+      y: false,
+      z: false
+    })
+  })
+
+  it('handles all true in first set', () => {
+    const controls1 = {
+      foo: true,
+      bar: true
+    }
+
+    const controls2 = {
+      foo: false,
+      bar: false
+    }
+
+    const result = mergeControls(controls1, controls2)
+
+    expect(result).toEqual({
+      foo: true,
+      bar: true
+    })
+  })
+
+  it('merges more than two control sets', () => {
+    const controls1 = {
+      a: true,
+      b: false,
+      c: false
+    }
+
+    const controls2 = {
+      a: false,
+      b: true,
+      c: false
+    }
+
+    const controls3 = {
+      a: false,
+      b: false,
+      c: true
+    }
+
+    const result = mergeControls(controls1, controls2, controls3)
+
+    expect(result.a).toBe(true)
+    expect(result.b).toBe(true)
+    expect(result.c).toBe(true)
+  })
+
+  it('works with different property names', () => {
+    const controls1 = {
+      thrust: true,
+      shield: false
+    }
+
+    const controls2 = {
+      thrust: false,
+      shield: true
+    }
+
+    const result = mergeControls(controls1, controls2)
+
+    expect(result.thrust).toBe(true)
+    expect(result.shield).toBe(true)
+  })
+
+  it('throws error when called with no arguments', () => {
+    expect(() => mergeControls()).toThrow(
+      'mergeControls requires at least one control set'
+    )
+  })
+})