Skip to content

Consolidate hooks in shell package #510

@tobeycodes

Description

@tobeycodes

We have some hooks in the settings package that are exported and used in other packages such as the shell. These are similar to hooks in db-react.

In my opinion these hooks should come from db-react instead. If we want settings to export hooks like this we should move a lot of db-react to settings such as useSetting but I think this does not belong there.

Some other things up for consideration:

  • Multiple hooks e.g. useAccountActive and useAccounts or we should rename it appropriately useAccountsAndAccountActive to reflect it's responsibility
  • Should useSortedAccounts become a default? Are there situations we would not want to sort accounts?
  • Some of these other hooks feel like they should also be in another package as they are simple wrappers over other functionality and might be used elsewhere outside of the settings context

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions