-
Notifications
You must be signed in to change notification settings - Fork 44
Open
Description
We have some hooks in the settings package that are exported and used in other packages such as the shell. These are similar to hooks in db-react.
In my opinion these hooks should come from db-react instead. If we want settings to export hooks like this we should move a lot of db-react to settings such as useSetting but I think this does not belong there.
Some other things up for consideration:
- Multiple hooks e.g.
useAccountActiveanduseAccountsor we should rename it appropriatelyuseAccountsAndAccountActiveto reflect it's responsibility - Should
useSortedAccountsbecome a default? Are there situations we would not want to sort accounts? - Some of these other hooks feel like they should also be in another package as they are simple wrappers over other functionality and might be used elsewhere outside of the settings context
beeman
Metadata
Metadata
Assignees
Labels
No labels