fix(cli): handle url imports for themer.sanity.build #11346

kbrabrand · 2025-12-01T09:56:44Z

Description

The PR adds an override for imports starting with https://themer.sanity.build/api/ that returns a Proxy object. This should be safe since the themes from the themer never impacts the exported schema.

This was done in response to https://linear.app/sanity/issue/CLDX-2705/validateextract-schema-fails-when-there-is-a-url-import-in reported by a user in #7602.

Testing

Tests have been added both for the importErrorHandler in isolation and a test verifying that the themer url imports work in a worker where the mockBrowserEnvironment is called. Has also been verified in a test project locally.

Notes for release

fix: handle URL import from the themer builder (Validate/extract schema fails when there is a url import in sanity.config.ts #7602)

vercel · 2025-12-01T09:56:51Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
page-building-studio	Ready	Preview	Comment	Dec 2, 2025 0:32am
test-studio	Ready	Preview	Comment	Dec 2, 2025 0:32am

3 Skipped Deployments

Project	Deployment	Preview	Updated (UTC)
e2e-studio	Ignored		Dec 2, 2025 0:32am
studio-workshop	Ignored	Preview	Dec 2, 2025 0:32am
test-next-studio	Ignored		Dec 2, 2025 0:32am

github-actions · 2025-12-01T09:57:05Z

🧪 E2E Preview environment

🔑 Environment Variables for Local Testing

This is the preview URL for the E2E tests: https://e2e-studio-lk5dfen03.sanity.dev

To run the E2E tests locally, you can use the following environment variables, then run pnpm test:e2e --ui to open the Playwright test runner.

💬 Remember to build the project first with pnpm build:e2e.

  SANITY_E2E_PROJECT_ID=ittbm412
  SANITY_E2E_BASE_URL=https://e2e-studio-lk5dfen03.sanity.dev
  SANITY_E2E_DATASET="update depending the project you want to test (pr-11346-chromium-19858571523 || pr-11346-firefox-19858571523 )"
  SANITY_E2E_DATASET_CHROMIUM=pr-11346-chromium-19858571523
  SANITY_E2E_DATASET_FIREFOX=pr-11346-firefox-19858571523

github-actions · 2025-12-01T09:57:06Z

📊 Playwright Test Report

Download Full E2E Report

This report contains test results, including videos of failing tests.

github-actions · 2025-12-01T10:01:45Z

⚡️ Editor Performance Report

Updated Tue, 02 Dec 2025 12:44:53 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	22.7 efps (44ms)	23.8 efps (42ms)	-2ms (-4.5%)	✅
article (body)	34.1 efps (29ms)	32.0 efps (31ms)	+2ms (+6.7%)	✅
article (string inside object)	27.4 efps (37ms)	26.3 efps (38ms)	+2ms (+4.1%)	✅
article (string inside array)	23.8 efps (42ms)	24.4 efps (41ms)	-1ms (-2.4%)	✅
recipe (name)	45.5 efps (22ms)	45.5 efps (22ms)	+0ms (-/-%)	✅
recipe (description)	66.7 efps (15ms)	71.4 efps (14ms)	-1ms (-/-%)	✅
recipe (instructions)	99.9+ efps (6ms)	99.9+ efps (5ms)	-1ms (-/-%)	✅
singleString (stringField)	58.8 efps (17ms)	55.6 efps (18ms)	+1ms (+5.9%)	✅
synthetic (title)	17.5 efps (57ms)	16.8 efps (60ms)	+3ms (+4.4%)	✅
synthetic (string inside object)	17.1 efps (59ms)	17.5 efps (57ms)	-2ms (-2.6%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	44ms	48ms	73ms	121ms	59ms	11.0s
article (body)	29ms	42ms	100ms	134ms	190ms	6.9s
article (string inside object)	37ms	39ms	51ms	85ms	3ms	5.8s
article (string inside array)	42ms	46ms	54ms	122ms	18ms	6.4s
recipe (name)	22ms	25ms	29ms	50ms	0ms	8.1s
recipe (description)	15ms	19ms	25ms	40ms	0ms	4.1s
recipe (instructions)	6ms	10ms	12ms	21ms	0ms	3.0s
singleString (stringField)	17ms	20ms	22ms	35ms	0ms	7.1s
synthetic (title)	57ms	59ms	71ms	137ms	252ms	15.1s
synthetic (string inside object)	59ms	61ms	104ms	129ms	204ms	7.7s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	42ms	47ms	73ms	108ms	41ms	10.3s
article (body)	31ms	39ms	74ms	174ms	164ms	6.7s
article (string inside object)	38ms	42ms	61ms	111ms	0ms	6.0s
article (string inside array)	41ms	45ms	50ms	111ms	1ms	6.3s
recipe (name)	22ms	25ms	35ms	57ms	0ms	7.2s
recipe (description)	14ms	17ms	21ms	37ms	0ms	4.1s
recipe (instructions)	5ms	9ms	10ms	31ms	0ms	3.0s
singleString (stringField)	18ms	19ms	24ms	50ms	0ms	6.3s
synthetic (title)	60ms	63ms	70ms	152ms	346ms	15.2s
synthetic (string inside object)	57ms	64ms	127ms	266ms	480ms	8.1s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

github-actions · 2025-12-01T10:01:45Z

⚡️ Editor Performance Report

Deploying studio and running performance tests…

github-actions · 2025-12-01T10:05:45Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	44.46%	64007 / 143956
🔵	Statements	44.46%	64007 / 143956
🔵	Functions	48.32%	3414 / 7064
🔵	Branches	79.32%	13028 / 16424

File Coverage

No changed files found.

Generated in workflow #46919 for commit a5ac793 by the Vitest Coverage Report Action

bjoerge

LGTM

kbrabrand · 2025-12-02T11:32:15Z

LGTM

Cool. I need an approval to be able to merge :)

(running the eFPS tests again before merging ofc.. they failed as per usual)

…uild

kbrabrand requested a review from a team as a code owner December 1, 2025 09:56

kbrabrand requested review from bjoerge and removed request for a team December 1, 2025 09:56

kbrabrand marked this pull request as draft December 1, 2025 10:09

kbrabrand force-pushed the cldx-2705/themer-http-import-fix branch from 018fcf3 to 2f3de31 Compare December 1, 2025 12:25

vercel bot deployed to Preview – test-studio December 1, 2025 12:30 View deployment

vercel bot deployed to Preview – page-building-studio December 1, 2025 12:30 View deployment

kbrabrand marked this pull request as ready for review December 1, 2025 13:47

kbrabrand force-pushed the cldx-2705/themer-http-import-fix branch from 48af160 to 20cea3b Compare December 2, 2025 09:06

vercel bot deployed to Preview – test-studio December 2, 2025 09:10 View deployment

vercel bot deployed to Preview – page-building-studio December 2, 2025 09:16 View deployment

bjoerge reviewed Dec 2, 2025

View reviewed changes

kbrabrand added 3 commits December 2, 2025 13:27

feat: add import error handler that ignores urls from themer.sanity.b…

3a6a5dd

…uild

test(importErrorHandler): add tests for import error handler

b710095

test(mockBrowser): test themer import handling

a5ac793

kbrabrand force-pushed the cldx-2705/themer-http-import-fix branch from 20cea3b to a5ac793 Compare December 2, 2025 12:27

vercel bot deployed to Preview – test-studio December 2, 2025 12:32 View deployment

vercel bot deployed to Preview – page-building-studio December 2, 2025 12:32 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(cli): handle url imports for themer.sanity.build #11346

fix(cli): handle url imports for themer.sanity.build #11346

kbrabrand commented Dec 1, 2025 •

edited

Loading

Uh oh!

vercel bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 1, 2025 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025 •

edited

Loading

Uh oh!

bjoerge left a comment

Uh oh!

kbrabrand commented Dec 2, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(cli): handle url imports for themer.sanity.build #11346

Are you sure you want to change the base?

fix(cli): handle url imports for themer.sanity.build #11346

Conversation

kbrabrand commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Notes for release

Uh oh!

vercel bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 E2E Preview environment

Uh oh!

github-actions bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Playwright Test Report

Uh oh!

github-actions bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

Uh oh!

github-actions bot commented Dec 1, 2025

⚡️ Editor Performance Report

Uh oh!

github-actions bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

bjoerge left a comment

Choose a reason for hiding this comment

Uh oh!

kbrabrand commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kbrabrand commented Dec 1, 2025 •

edited

Loading

vercel bot commented Dec 1, 2025 •

edited

Loading

github-actions bot commented Dec 1, 2025 •

edited

Loading

github-actions bot commented Dec 1, 2025 •

edited

Loading

github-actions bot commented Dec 1, 2025 •

edited

Loading

github-actions bot commented Dec 1, 2025 •

edited

Loading

kbrabrand commented Dec 2, 2025 •

edited

Loading