WIP

Author: jemc

core/CPointer.savi

@@ -61,7 +61,7 @@
   :: The caller is expected to only do this for indexes that are within
   :: the size of the originally allocated pointer and not to reach outside
   :: that bounds into memory owned by other pointers.
-  :fun box _offset(index USize) @'ref: compiler intrinsic
+  :fun _offset(index USize) @'ref: compiler intrinsic
 
   :: Get a pointer that points to a subset of this original pointer's memory,
   :: starting at the given element index from the current pointer's address,
@@ -78,7 +78,7 @@
   :: Return an alias of the element at the given index.
   ::
   :: The caller is expected to only do this for in-bounds indexes.
-  :fun box _get_at(index USize) (@->A)'aliased: compiler intrinsic
+  :fun _get_at(index USize) (@->A)'aliased: compiler intrinsic
 
   :: Return the element at the given index, without capability aliasing.
   :: This lack of aliasing breaks capability safety, so the caller is expected
@@ -106,7 +106,7 @@
   :: you need to copy starting at some offset, use the `_offset` method first.
   ::
   :: The caller is expected to only do this for in-bounds element counts.
-  :fun box _copy_to(other @'ref, count USize) None: compiler intrinsic
+  :fun _copy_to(other @'ref, count USize) None: compiler intrinsic
 
   :: Compare the memory referenced by this pointer to that of the other pointer,
   :: across the byte range indicated by the given element count.
@@ -119,7 +119,7 @@
   :: ramifications of what kind of representation the element has in its memory.
   ::
   :: The caller is expected to only do this for in-bounds element counts.
-  :fun box _compare(other @'box, count USize) I32: compiler intrinsic
+  :fun _compare(other @'box, count USize) I32: compiler intrinsic
 
   :: Calculate the hash of the block of memory starting at this pointer's head,
   :: continuing through the given number of elements in that memory.
@@ -132,7 +132,7 @@
   :: ramifications of what kind of representation the element has in its memory.
   ::
   :: The caller is expected to only do this for in-bounds element counts.
-  :fun box _hash(count USize) USize: compiler intrinsic
+  :fun _hash(count USize) USize: compiler intrinsic
 
   :: Return True if this is a null pointer (i.e. a zero address).
   :fun tag is_null Bool: compiler intrinsic

core/Env.savi

@@ -14,8 +14,8 @@
   :: distribute more limited authority objects derived from it) as needed.
   :new val _create(
     argc I32
-    argv CPointer(CPointer(U8)'ref)'ref
-    envp CPointer(CPointer(U8)'ref)'ref
+    argv CPointer(CPointer(U8)'ref)'ref // TODO: val instead of ref
+    envp CPointer(CPointer(U8)'ref)'ref // TODO: val instead of ref
   )
     @args = []
     i = USize[0]
@@ -41,7 +41,7 @@
   :let _vars Array(Pair(String))
 
   :new val _from_envp(envp CPointer(CPointer(U8)'ref)'ref)
-    @_vars = []
+    vars = []
     if (envp.is_not_null) (
       while True (
         arg = envp._get_at(0)
@@ -50,12 +50,13 @@
         try (
           len = _FFI.strlen(arg).usize
           pair = String.val_from_cpointer(arg, len, len).split2!('=')
-          @_vars.push(pair)
+          vars.push(pair)
         )
 
         envp = envp._offset(1)
       )
     )
+    @_vars = vars
 
   :fun each_pair
     :yields (String'val, String'val) for None

core/IntoString.savi

@@ -5,7 +5,7 @@
 :trait box IntoString
   :: Emit a representation of this value into the given String, preserving
   :: its isolation and returning the String with the new content appended.
-  :fun box into_string(out String'iso) String'iso
+  :fun into_string(out String'iso) String'iso
 
   :: Return a conservative estimate for how much many bytes are required to hold
   :: the string representation of this value when emitted with `into_string`.
@@ -14,4 +14,4 @@
   :: is not possible, the function should prefer to over-estimate the amount
   :: of space needed, because an under-estimation would result in a potentially
   :: costly re-allocation and copy of data in the underlying string buffer.
-  :fun box into_string_space USize
+  :fun into_string_space USize

core/None.savi

@@ -1,9 +1,8 @@
 :module None
   :is IntoString
-  // TODO: These shouldn't need to be `:fun box` - `:fun non` should be okay.
   :: When emitting into a string, emit nothing (i.e. an empty string).
-  :fun box into_string(out String'iso): --out
-  :fun box into_string_space USize: 0
+  :fun into_string(out String'iso): --out
+  :fun into_string_space USize: 0
 
   :: When inspecting, print explicitly using the name `None`.
-  :fun box inspect_into(out String'iso): out << "None", --out
+  :fun inspect_into(out String'iso): out << "None", --out

core/U64.BCD.savi

@@ -1,5 +1,5 @@
 :: Binary Coded Decimal (BCD) representation of an U64 integer.
-:: 
+::
 :: Each digit is represented by a nibble (4 bits), requiring
 :: a total of 80 bits for up to 20 digits of the U64.
 :: Digits are stored in reverse order, so the the decimal `123`
@@ -19,8 +19,8 @@
   :let _high U64
   :let _low U64
 
-  :new (u64 U64)
-    high U64 = 0 
+  :new val (u64 U64)
+    high U64 = 0
     low U64 = 0xF
     ndigits U64 = 0
     while True (
@@ -36,11 +36,11 @@
     @_high = high.bit_or(ndigits.bit_shl(58))
     @_low = low
 
-  :fun box is_zero Bool
+  :fun is_zero Bool
     @_low.bit_and(0xFF) == 0xF0
 
   :: Converts the BCD back to an U64
-  :fun box u64 U64
+  :fun u64 U64
     n U64 = 0
     @each_digit -> (digit |
       n = (n * 10) + digit.u64
@@ -49,11 +49,11 @@
 
   :: Returns the number of digits.
   ::
-  :fun box ndigits USize
+  :fun ndigits USize
     @_high.bit_shr(58).bit_and(0b11111).usize
 
   :: Returns digit at position `pos`.
-  :fun box digit!(pos USize) U8
+  :fun digit!(pos USize) U8
     // 1234  -> 0xF_4321
     // pos=0 ->     ^-- index=3       == ndigits - (pos + 1)
     // pos=3 ->        ^-- index=0    == ndigits - (pos + 1)
@@ -68,8 +68,8 @@
       @_high.bit_shr(((index - 16) * 4).u8).u8.bit_and(U8[0xF])
     )
 
-  :fun box each_digit
-    :yields U8 for None 
+  :fun each_digit
+    :yields U8 for None
     high = @_high
     low = @_low
     while (low.bit_and(0xF) != 0xF) (
@@ -78,10 +78,10 @@
       high = high.bit_shr(4)
     )
 
-  :fun box into_string_space USize
+  :fun into_string_space USize
     @ndigits
 
-  :fun box into_string(out String'iso) String'iso
+  :fun into_string(out String'iso) String'iso
     @each_digit -> (digit |
       out.push_byte('0'.u8 + digit)
     )

core/declarators/declarators.savi

@@ -317,8 +317,8 @@
   :context type
   :begins function
 
-  :term cap enum (iso, val, ref, box, tag, non)
-    :default box
+  :term cap enum (iso, val, ref, box, tag, non, read)
+    :default read
   :term name_and_params NameMaybeWithParams
   :term ret Type
     :optional
@@ -339,8 +339,8 @@
   :context type
   :begins function
 
-  :term cap enum (iso, val, ref, box, tag, non)
-    :optional // TODO: :default: @type.cap
+  :term cap enum (iso, val, ref, box, tag, non, read)
+    :default read
   :term name_and_params NameMaybeWithParams
   :body optional
 
@@ -350,8 +350,8 @@
   :context type
   :begins function
 
-  :term cap enum (iso, val, ref, box, tag, non)
-    :optional // TODO: :default: @type.cap
+  :term cap enum (iso, val, ref, box, tag, non, read)
+    :default read
   :term params Params
     :optional
   :body optional

spec/compiler/completeness.savi.spec.md

@@ -14,7 +14,7 @@ It complains when not all fields get initialized in a constructor:
 ```
 ```error
 This constructor doesn't initialize all of its fields:
-  :new
+  :new ref
    ^~~
 
 - this field didn't get initialized:
@@ -52,7 +52,7 @@ It complains when a field is only conditionally initialized:
 ```
 ```error
 This constructor doesn't initialize all of its fields:
-  :new
+  :new ref
    ^~~
 
 - this field didn't get initialized:
@@ -104,7 +104,7 @@ It won't blow its stack on mutually recursive branching paths:
 ```
 ```error
 This constructor doesn't initialize all of its fields:
-  :new
+  :new ref
    ^~~
 
 - this field didn't get initialized:

spec/compiler/t_type_check.calls.savi.spec.md

@@ -309,13 +309,13 @@ TODO: It complains when calling a `non` function with no body on a `non` referen
   // t_non.no_body
 
 :trait TraitNon
-  :fun box not_non String
+  :fun not_non String
   :fun non with_body String: "with_body"
   :fun non no_body String
 
 :class TraitNonClass
   :is TraitNon
-  :fun box not_non String: "not_non"
+  :fun not_non String: "not_non"
   :fun non no_body String: "no_body"
 
 ```

spec/compiler/type_check.calls.savi.spec.md

@@ -224,7 +224,7 @@ This function call doesn't meet subtyping requirements:
     string String'val = wrapper.immutable_string
                                 ^~~~~~~~~~~~~~~~
 
-- the function's required receiver capability is `val` but only a `ref` or `box` function can be auto-recovered:
+- the function's required receiver capability is `val` but only a `ref`, `box`, or `read` function can be auto-recovered:
   :fun val immutable_string: @string
        ^~~
 
@@ -365,6 +365,8 @@ A `let` property can only be assigned inside a constructor:
        ^
 ```
 
+---
+
 It complains when calling a `non` function with no body on a `non` reference to a trait:
 
 ```savi

spec/compiler/type_check.completeness.savi.spec.md

@@ -19,21 +19,25 @@ It complains when access to the self is shared while still incomplete:
     any
 ```
 ```error
-This usage of `@` shares field access to the object from a constructor before all fields are initialized:
+The type of this expression doesn't meet the constraints imposed on it:
     AccessWhileIncomplete.data(@)
                                ^
 
-- if this constraint were specified as `tag` or lower it would not grant field access:
+- it is required here to be a subtype of Any'box:
   :fun data(any Any'box)
                 ^~~~~~~
 
-- this field didn't get initialized:
-  :var y U64
-       ^
+- but the type of the receiver value was ItComplainsWhenAccessToTheSelfIsSharedWhileStillIncomplete0'tag:
+    AccessWhileIncomplete.data(@)
+                               ^
 
-- this field didn't get initialized:
-  :var z U64
-       ^
+- this can be reached while in an incomplete constructor (that is, before all fields are initialized) so it's not safe to share publicly here:
+    AccessWhileIncomplete.data(@)
+                               ^
+
+- it can be reached from this constructor:
+  :new ref
+   ^~~
 ```
 
 ---