chore: improve pyproject.toml from sp-repo-review checks (#2623)

* Update Ruff pre-commit hook to v0.12.0 to use ruff-check.
* Apply revisions to pass more of sp-repo-review.
   - RF003 src directory doesn't need to be specified anymore (0.6+)
   - Use "INFO" to avoid Error: tool.pytest.ini_options.log_cli_level must
     be valid exactly by one definition.
* Remove License trove classifier as using SPDX project license.

---------

Signed-off-by: Henry Schreiner <[email protected]>
Co-authored-by: Matthew Feickert <[email protected]>

Author: henryiii

.pre-commit-config.yaml

@@ -35,9 +35,9 @@ repos:
     - id: rst-inline-touching-normal
 
 - repo: https://github.com/astral-sh/ruff-pre-commit
-  rev: "v0.8.1"
+  rev: "v0.12.0"
   hooks:
-    - id: ruff
+    - id: ruff-check
       args: ["--fix", "--show-fixes"]
 
 -   repo: https://github.com/psf/black-pre-commit-mirror

pyproject.toml

@@ -10,7 +10,7 @@ name = "pyhf"
 dynamic = ["version"]
 description = "pure-Python HistFactory implementation with tensors and autodiff"
 readme = "README.rst"
-license = { text = "Apache-2.0" }  # SPDX short identifier
+license = "Apache-2.0"
 requires-python = ">=3.8"
 authors = [
     { name = "Lukas Heinrich", email = "[email protected]" },
@@ -29,7 +29,6 @@ classifiers = [
     "Development Status :: 4 - Beta",
     "Environment :: WebAssembly :: Emscripten",
     "Intended Audience :: Science/Research",
-    "License :: OSI Approved :: Apache Software License",
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3",
     "Programming Language :: Python :: 3 :: Only",
@@ -172,7 +171,7 @@ addopts = [
     "--doctest-modules",
     "--doctest-glob='*.rst'",
 ]
-log_cli_level = "info"
+log_cli_level = "INFO"
 testpaths = "tests"
 markers = [
     "fail_jax",
@@ -262,26 +261,20 @@ module = [
 ignore_errors = true
 
 [tool.ruff]
-src = ["src"]
 line-length = 88
 
 [tool.ruff.lint]
-select = [
-  "E", "F", "W", # flake8
+extend-select = [
   "UP",          # pyupgrade
   "RUF",         # Ruff-specific
   "TID",         # flake8-tidy-imports
 ]
 ignore = [
   "E402",
-  "E501",
   "RUF001", # String contains ambiguous unicode character
   "RUF005", # unpack-instead-of-concatenating-to-collection-literal
 ]
 typing-modules = ["pyhf.typing"]
-unfixable = [
-  "F841", # Removes unused variables
-]
 flake8-tidy-imports.ban-relative-imports = "all"
 
 [tool.ruff.lint.per-file-ignores]