Skip to content

Conversation

@matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Oct 1, 2025

Description

  • Remove support for TensorFlow from the codebase.
    • This is a breaking change.
    • Remove the TensorFlow backend and optimize/opt_tflow.py.
  • Remove use of TensorFlow from the tests.
    • Remove TensorFlow lower bounds from tests/constraints.txt.
  • Remove all docs and examples that mention or use TensorFlow.
  • Remove mentions of TensorFlow in all parts of the website and REAMDE except for historical purposes like the release notes, JOSS paper, and notes about early pyhf research in FAQs.

Factorizes out parts of PR #2566 and removes additional documentation pieces.

Affected issues

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Remove support for TensorFlow from the codebase.
   - This is a breaking change.
   - Remove the TensorFlow backend and optimize/opt_tflow.py.
* Remove use of TensorFlow from the tests.
   - Remove TensorFlow lower bounds from tests/constraints.txt.
* Remove all docs and examples that mention or use TensorFlow.
* Remove mentions of TensorFlow in all parts of the website and REAMDE
  except for historical purposes like the release notes, JOSS paper, and
  notes about early pyhf research in FAQs.

Co-authored-by: Giordon Stark <[email protected]>

@matthewfeickert matthewfeickert self-assigned this Oct 1, 2025
@matthewfeickert matthewfeickert added the feat/enhancement New feature or request label Oct 1, 2025
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.25%. Comparing base (8d23b82) to head (8c55665).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2609      +/-   ##
==========================================
+ Coverage   98.23%   98.25%   +0.01%     
==========================================
  Files          69       67       -2     
  Lines        4545     4360     -185     
  Branches      612      600      -12     
==========================================
- Hits         4465     4284     -181     
+ Misses         48       46       -2     
+ Partials       32       30       -2     
Flag Coverage Δ
contrib 97.88% <ø> (+0.06%) ⬆️
doctest 98.11% <ø> (+0.01%) ⬆️
unittests-3.10 96.26% <ø> (+<0.01%) ⬆️
unittests-3.11 96.26% <ø> (+<0.01%) ⬆️
unittests-3.12 96.26% <ø> (+<0.01%) ⬆️
unittests-3.8 96.26% <ø> (+<0.01%) ⬆️
unittests-3.9 96.30% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this to In progress in pyhf v0.8.0 Oct 1, 2025
@matthewfeickert matthewfeickert added the Breaking Results in a known breaking change label Oct 1, 2025
@matthewfeickert matthewfeickert marked this pull request as ready for review October 1, 2025 00:15
@matthewfeickert matthewfeickert requested a review from kratsg October 1, 2025 00:16
@kratsg kratsg merged commit a4eefc5 into scikit-hep:main Oct 1, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in pyhf v0.8.0 Oct 1, 2025
@matthewfeickert matthewfeickert deleted the feat/remove-tensorflow branch October 1, 2025 02:43
matthewfeickert added a commit that referenced this pull request Oct 15, 2025
* Use uv for all installations in CI, as the Python 3.8 fall back to
  'pip install' was needed only for TensorFlow.
   - Amends PR #2609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking Results in a known breaking change feat/enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Minuit and Tensorflow give different results Investigate using TensorFlow v2.0 with lazy evaluation

2 participants