-
Notifications
You must be signed in to change notification settings - Fork 91
feat: Remove support for PyTorch backend #2611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove support for PyTorch backend #2611
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2611 +/- ##
==========================================
- Coverage 98.25% 98.23% -0.03%
==========================================
Files 67 65 -2
Lines 4360 4193 -167
Branches 600 591 -9
==========================================
- Hits 4284 4119 -165
+ Misses 46 45 -1
+ Partials 30 29 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| >>> a = pyhf.tensorlib.astensor([[10, 7, 4], [3, 2, 1]]) | ||
| >>> pyhf.tensorlib.percentile(a, 50) | ||
| 3.5 | ||
| np.float64(3.5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that docstrings for NumPy got updated as NumPy can now be NumPy v2.0 and so the docstest changed.
78744ce to
d9c025d
Compare
Description
optimize/opt_pytorch.py.tests/constraints.txt.tests/test_backend_consistency.pyas there is only NumPy and JAX now.Factorizes out parts of PR #2566 and removes additional documentation pieces.
Affected Issues
InvalidBackendexception #2605Please describe the purpose of this pull request in some detail. Reference and link to any relevant issues or pull requests.
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: