Skip to content

Commit 71222ef

Browse files
Merge pull request #2038 from Curtisjnes/feature_enableMobileMenu
bump ace-builds up to 1.36.3 and added their new enableMobileMenu option
2 parents f3263ca + 2ac06cb commit 71222ef

File tree

4 files changed

+27
-5
lines changed

4 files changed

+27
-5
lines changed

example/index.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ class App extends Component {
115115
fontSize: 14,
116116
lineHeight: 19,
117117
showGutter: true,
118+
enableMobileMenu: true,
118119
showPrintMargin: true,
119120
highlightActiveLine: true,
120121
enableSnippets: false,
@@ -253,6 +254,23 @@ class App extends Component {
253254
Enable Live Autocomplete
254255
</label>
255256
</p>
257+
</div>
258+
<div className="field">
259+
<p className="control">
260+
<label className="checkbox">
261+
<input
262+
type="checkbox"
263+
checked={this.state.enableMobileMenu}
264+
onChange={e =>{
265+
this.setBoolean(
266+
"enableMobileMenu",
267+
e.target.checked
268+
)
269+
}}
270+
/>
271+
Enable Mobile Menue
272+
</label>
273+
</p>
256274
</div>
257275
<div className="field">
258276
<p className="control">
@@ -346,6 +364,7 @@ class App extends Component {
346364
setOptions={{
347365
useWorker: false,
348366
enableBasicAutocompletion: this.state.enableBasicAutocompletion,
367+
enableMobileMenu: this.state.enableMobileMenu,
349368
enableLiveAutocompletion: this.state.enableLiveAutocompletion,
350369
enableSnippets: this.state.enableSnippets,
351370
showLineNumbers: this.state.showLineNumbers,
@@ -376,6 +395,7 @@ class App extends Component {
376395
enableBasicAutocompletion: ${this.state.enableBasicAutocompletion},
377396
enableLiveAutocompletion: ${this.state.enableLiveAutocompletion},
378397
enableSnippets: ${this.state.enableSnippets},
398+
enableMobileMenu: ${this.state.enableMobileMenu},
379399
showLineNumbers: ${this.state.showLineNumbers},
380400
tabSize: 2,
381401
}}/>

package-lock.json

Lines changed: 5 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"react"
6969
],
7070
"dependencies": {
71-
"ace-builds": "^1.32.8",
71+
"ace-builds": "^1.36.3",
7272
"diff-match-patch": "^1.0.5",
7373
"lodash.get": "^4.4.2",
7474
"lodash.isequal": "^4.5.0",

src/ace.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ export interface IAceEditorProps {
4747
debounceChangePeriod?: number;
4848
enableBasicAutocompletion?: boolean | string[];
4949
enableLiveAutocompletion?: boolean | string[];
50+
enableMobileMenu?: boolean;
5051
tabSize?: number;
5152
value?: string;
5253
placeholder?: string;

0 commit comments

Comments
 (0)