fix(task_params): null pointer

Author: fiftin

api/integration.go

@@ -5,13 +5,14 @@ import (
 	"crypto/sha256"
 	"encoding/json"
 	"fmt"
-	"github.com/semaphoreui/semaphore/pkg/conv"
-	"github.com/semaphoreui/semaphore/services/server"
-	task2 "github.com/semaphoreui/semaphore/services/tasks"
 	"io"
 	"net/http"
 	"strings"
 
+	"github.com/semaphoreui/semaphore/pkg/conv"
+	"github.com/semaphoreui/semaphore/services/server"
+	task2 "github.com/semaphoreui/semaphore/services/tasks"
+
 	"github.com/semaphoreui/semaphore/api/helpers"
 	"github.com/semaphoreui/semaphore/db"
 	log "github.com/sirupsen/logrus"
@@ -270,8 +271,16 @@ func GetTaskDefinition(integration db.Integration, payload []byte, r *http.Reque
 
 	var extractedEnvResults = Extract(envValues, r, payload)
 
-	taskDefinition = integration.TaskParams.CreateTask()
-	taskDefinition.TemplateID = integration.TemplateID
+	if integration.TaskParams != nil {
+		taskDefinition = integration.TaskParams.CreateTask(integration.TemplateID)
+	} else {
+		taskDefinition = db.Task{
+			ProjectID:  integration.ProjectID,
+			TemplateID: integration.TemplateID,
+		}
+	}
+
+	taskDefinition.IntegrationID = &integration.ID
 
 	var env map[string]any
 	err = json.Unmarshal([]byte(taskDefinition.Environment), &env)

db/TaskParams.go

@@ -20,7 +20,7 @@ type TaskParams struct {
 	Params MapStringAnyField `db:"params" json:"params,omitempty"`
 }
 
-func (p TaskParams) CreateTask() (task Task) {
+func (p TaskParams) CreateTask(templateID int) (task Task) {
 	task = Task{
 		ProjectID:   p.ProjectID,
 		Environment: p.Environment,
@@ -30,6 +30,7 @@ func (p TaskParams) CreateTask() (task Task) {
 		Version:     p.Version,
 		InventoryID: p.InventoryID,
 		Params:      p.Params,
+		TemplateID:  templateID,
 	}
 
 	return

services/schedules/SchedulePool.go

@@ -1,12 +1,13 @@
 package schedules
 
 import (
-	"github.com/semaphoreui/semaphore/services/server"
-	"github.com/semaphoreui/semaphore/util"
 	"strconv"
 	"sync"
 	"time"
 
+	"github.com/semaphoreui/semaphore/services/server"
+	"github.com/semaphoreui/semaphore/util"
+
 	"github.com/robfig/cron/v3"
 	"github.com/semaphoreui/semaphore/db"
 	"github.com/semaphoreui/semaphore/db_lib"
@@ -103,8 +104,7 @@ func (r ScheduleRunner) Run() {
 		return
 	}
 
-	task := schedule.TaskParams.CreateTask()
-	task.TemplateID = schedule.TemplateID
+	task := schedule.TaskParams.CreateTask(schedule.TemplateID)
 	task.ScheduleID = &schedule.ID
 
 	_, err = r.pool.taskPool.AddTask(