chore: fix SHA passed to e2e-tests workflow (#699)

* chore: fix SHA passed to e2e-tests workflow

* update SHA to be PR sha if available

* update checkout ref

* fix syntax error

Author: dphang

.github/workflows/CI.yml

@@ -60,5 +60,6 @@ jobs:
           token: ${{ secrets.BOT_GITHUB_TOKEN }}
           ref: ${{ github.event.pull_request.head.ref || github.ref }}
           # FIXME: Passing sha doesn't seem to work, created GitHub ticket here: https://github.community/t/workflow-dispatch-cant-set-ref-to-commit-sha/138132
-          # But using ref (branch name) should be fine as it means tests always run on latest commit on PR or master branch
+          # So for now we pass in SHA as an input
           # ref: ${{ github.event.pull_request.head.sha || github.sha }}
+          inputs: '{"sha": "${{ github.event.pull_request.head.sha || github.sha }}"}'

.github/workflows/e2e-tests.yml

@@ -7,6 +7,10 @@ on:
         description: "Pull Request ID"
         required: false
         default: ""
+      sha:
+        description: "GitHub SHA"
+        required: false
+        default: ""
 
 jobs:
   initialize:
@@ -43,7 +47,7 @@ jobs:
           context: "End-to-end Tests"
           description: "Waiting for end-to-end tests to pass"
           state: "pending"
-          sha: ${{ steps.set_pr_git_sha.outputs.pr_git_sha || github.sha }}
+          sha: ${{ steps.set_pr_git_sha.outputs.pr_git_sha || github.event.inputs.sha || github.sha }}
           target_url: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}
 
   run-e2e-tests:
@@ -64,6 +68,8 @@ jobs:
       # For non-fork PRs
       - uses: actions/checkout@v2
         if: ${{ github.event.inputs.pull_request_id == '' }}
+        with:
+          ref: ${{ github.event.inputs.sha || github.ref }}
 
       # For manually run PRs
       - name: Initialize empty git repository
@@ -116,7 +122,7 @@ jobs:
           context: "End-to-end Tests"
           description: "End-to-end tests have failed"
           state: "failure"
-          sha: ${{ needs.initialize.outputs.pr_git_sha || github.sha }}
+          sha: ${{ needs.initialize.outputs.pr_git_sha || github.event.inputs.sha || github.sha }}
           target_url: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}
 
   finalize:
@@ -133,5 +139,5 @@ jobs:
           context: "End-to-end Tests"
           description: "End-to-end tests have passed"
           state: "success"
-          sha: ${{ needs.initialize.outputs.pr_git_sha || github.sha }}
+          sha: ${{ needs.initialize.outputs.pr_git_sha || github.event.inputs.sha || github.sha }}
           target_url: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}