-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[CI] Tiny speed up VLM CI #14517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Tiny speed up VLM CI #14517
Conversation
Summary of ChangesHello @b8zhong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on optimizing the Continuous Integration (CI) pipeline for Vision-Language Models (VLM) by implementing changes designed to reduce test execution time. This is achieved through increasing the batch processing size for evaluations and substituting a larger VLM model with a more lightweight alternative for testing purposes, which in turn necessitated updates to the expected test durations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to speed up the VLM CI by increasing the batch size for tests and switching to a smaller model. The changes are logical and directly support this goal. I have one suggestion to improve maintainability by replacing a duplicated magic number with a constant.
| tp = 1 | ||
| tasks = "mmmu_val" | ||
| batch_size = 32 | ||
| batch_size = 64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The batch size is now hardcoded to 64 in two places: here as batch_size, and in _run_vlm_mmmu_test for the --cuda-graph-max-bs argument (line 140). This could lead to inconsistencies if one is updated but not the other. To improve maintainability, consider defining this value as a constant at the module level (e.g., VLM_BATCH_SIZE = 64) and reusing it in both locations. This would ensure they always stay in sync.
|
/tag-and-rerun-ci |
Co-authored-by: Brayden Zhong <[email protected]>
Co-authored-by: Brayden Zhong <[email protected]>
Co-authored-by: Brayden Zhong <[email protected]>
Co-authored-by: Brayden Zhong <[email protected]>
#14510