[CI] Migrate Eagle 1-GPU tests to test/registered/ #14529
Merged
+58
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonshao
requested review from
Fridge003,
Kangyan-Zhou,
ispobock and
merrymercy
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
/tag-and-rerun-ci |
Collaborator
Author
Move Eagle 1-GPU tests from test/srt/ to test/registered/eagle/ as part of the CI registry migration. Changes: - Move 5 Eagle test files to test/registered/eagle/ - Add CI registry decorators with suite="stage-b-test-small-1-gpu" - Add stage-b-test-small-1-gpu suite to test/run_suite.py - Add stage-b-test-small-1-gpu job to pr-test.yml (4 partitions) - Remove Eagle entries from test/srt/run_suite.py
alisonshao
force-pushed
the
migrate-eagle-1gpu-tests-to-registered
branch
from
7bbb26f to
35ff902
Compare
hnyls2002
requested changes
Dec 7, 2025
Collaborator
hnyls2002
left a comment
hnyls2002
left a comment
There was a problem hiding this comment.
I would suggest to place eagle/ under another layer of spec, e.g. registered/spec/eagle
hnyls2002
approved these changes
Dec 7, 2025
Collaborator
hnyls2002
left a comment
hnyls2002
left a comment
There was a problem hiding this comment.
Also consider putting test_build_eagle_tree.py under spec/utils, which is a normal part for all the spec backends.
- Place eagle/ under registered/spec/eagle/ as suggested - Move test_build_eagle_tree.py to spec/utils/ as a common utility
alisonshao
force-pushed
the
migrate-eagle-1gpu-tests-to-registered
branch
from
f8c79f9 to
bb78714
Compare
Collaborator
|
@alisonshao CI failed. |
Kevin-XiongC
pushed a commit
to novitalabs/sglang
that referenced
this pull request
Dec 9, 2025
JustinTong0323
pushed a commit
to JustinTong0323/sglang
that referenced
this pull request
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
test/srt/totest/registered/eagle/suite="stage-b-test-small-1-gpu"stage-b-test-small-1-gpusuite totest/run_suite.pyPER_COMMIT_SUITESstage-b-test-small-1-gpujob topr-test.ymlwith 4 partitionstest/srt/run_suite.pyFiles Migrated
Test plan
stage-b-test-small-1-gpujob runs in CI