Spike: Adding Llamaindex llm instrumentation #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core Implementation:
_handle_llm_start(): Captures model name, input messages, creates LLMInvocation entity
_handle_llm_end(): Extracts response content, token usage, finalizes span
Handles LlamaIndex-specific message formats (ChatMessage objects, blocks[0].text structure)
Supports both dict and object response types
Token extraction from response.raw.usage (OpenAI format)
Testing:
test_llm_instrumentation.py: Live OpenAI API integration test
Validates span attributes, message content, token counts
Verifies metrics emission
Documentation:
Quick start guide with code example
Expected span attributes and metrics output
Key differences vs LangChain (event-based callbacks, CBEventType enum)
Span Attributes (Gen AI Semantic Conventions)
Metrics:
gen_ai.client.operation.duration (histogram)
gen_ai.client.token.usage (counter)