Enable signing with --detached-sign flag. (#657)

wlynch · web-flow · commit 6908cfd29100 · 2025-03-25T15:07:09.000-04:00
It was pointed out to me that gitsign doesn't work with jj out of the
box. This is because jj invokes gpg commands with `-abu` instead of
git's `-bsau`.

-s = --sign, but -b = --detached-sign, which feels like should also
enable signing mode. This change allows signing to be done if either
flag is set.

Signed-off-by: Billy Lynch &lt;billy@chainguard.dev&gt;
diff --git a/internal/commands/root/root.go b/internal/commands/root/root.go
@@ -76,7 +76,7 @@ func New(cfg *config.Config) *cobra.Command {
 							return item.RunE(item, cmd.Flags().Args())
 						}
 					}
-				case o.FlagSign:
+				case o.FlagSign, o.FlagDetachedSignature:
 					return commandSign(o, s, args...)
 				case o.FlagVerify:
 					return commandVerify(o, s, args...)

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ func New(cfg config.Config) cobra.Command {`
`76`	`76`	`return item.RunE(item, cmd.Flags().Args())`
`77`	`77`	`}`
`78`	`78`	`}`
`79`		`- case o.FlagSign:`
	`79`	`+ case o.FlagSign, o.FlagDetachedSignature:`
`80`	`80`	`return commandSign(o, s, args...)`
`81`	`81`	`case o.FlagVerify:`
`82`	`82`	`return commandVerify(o, s, args...)`